Export MBeans to Sling Metrics

[Jörg Hoh <jh...@googlemail.com.INVALID>]

Hi,

I am currently trying to make Jetty MBeans available as Sling Metrics, so
we can post-process them from there. I thought about integrating it
directly in the Felix HTTP module, but the functionality is quite generic,
and there might be code around, which already supports MBeans for
monitoring but no (Sling) Metrics.

I pushed a first simple version to the Sling Whiteboard (
https://github.com/apache/sling-whiteboard/tree/master/jmx-exporter) for
review.

What is your opinion? Would such a simple and small bundle be benefical for
Sling or should I rather try to get it directly in Felix, as Jetty is the
only real usecase for such a feature?

Jörg

-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

Re: Export MBeans to Sling Metrics

[Robert Munteanu <ro...@apache.org>]

On Fri, 2022-03-04 at 13:21 +0100, Jörg Hoh wrote:
> Hi Robert,
> 
> Am Mi., 2. März 2022 um 15:41 Uhr schrieb Robert Munteanu <
> rombert@apache.org>:
> 
> > Hi Jörg,
> > 
> > On Tue, 2022-03-01 at 17:59 +0100, Jörg Hoh wrote:
> > > Hi,
> > 
> > > https://github.com/apache/sling-whiteboard/tree/master/jmx-exporter
> > > )
> > 
> > Since the bundle exports JMX information as _Sling_ metrics, I
> > think it
> > should end up in Sling.
> > 
> 
> Technically it is not hard to switch to the Codahale API directly,
> which
> could make it more universablly usable, even outside of Sling.

Yes, technically. The Sling Metrics docs page [1] lists the reasons for
having wrapper interfaces. I am not sure if they still stand since I'm
not a heavy user of that bundle. But that is the current state.

> > 
> > It's worth mentioning that the Sling metrics bundle does not depend
> > on
> > other Sling bundles at runtime, and as such is a good candidate for
> > moving to Felix, but I think that's a longer discussion.
> > 
> > 
> Maybe we can develop it here and then see if we can move it more
> upstream
> into Felix at a later point (as we did with the healthchecks).

That sounds like a resonable approach to me.

Thanks,
Robert

[1]: https://sling.apache.org/documentation/bundles/metrics.html

Re: Export MBeans to Sling Metrics

[Jörg Hoh <jh...@googlemail.com.INVALID>]

Hi Robert,

Am Mi., 2. März 2022 um 15:41 Uhr schrieb Robert Munteanu <
rombert@apache.org>:

> Hi Jörg,
>
> On Tue, 2022-03-01 at 17:59 +0100, Jörg Hoh wrote:
> > Hi,
>
> > https://github.com/apache/sling-whiteboard/tree/master/jmx-exporter)
>
> Since the bundle exports JMX information as _Sling_ metrics, I think it
> should end up in Sling.
>

Technically it is not hard to switch to the Codahale API directly, which
could make it more universablly usable, even outside of Sling.


>
> It's worth mentioning that the Sling metrics bundle does not depend on
> other Sling bundles at runtime, and as such is a good candidate for
> moving to Felix, but I think that's a longer discussion.
>
>
Maybe we can develop it here and then see if we can move it more upstream
into Felix at a later point (as we did with the healthchecks).

Jörg


-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

Re: Export MBeans to Sling Metrics

[Robert Munteanu <ro...@apache.org>]

Hi Jörg,

On Tue, 2022-03-01 at 17:59 +0100, Jörg Hoh wrote:
> Hi,
> 
> I am currently trying to make Jetty MBeans available as Sling
> Metrics, so
> we can post-process them from there. I thought about integrating it
> directly in the Felix HTTP module, but the functionality is quite
> generic,
> and there might be code around, which already supports MBeans for
> monitoring but no (Sling) Metrics.
> 
> I pushed a first simple version to the Sling Whiteboard (
> https://github.com/apache/sling-whiteboard/tree/master/jmx-exporter)
> for
> review.
> 
> What is your opinion? Would such a simple and small bundle be
> benefical for
> Sling or should I rather try to get it directly in Felix, as Jetty is
> the
> only real usecase for such a feature?

Since the bundle exports JMX information as _Sling_ metrics, I think it
should end up in Sling.

It's worth mentioning that the Sling metrics bundle does not depend on
other Sling bundles at runtime, and as such is a good candidate for
moving to Felix, but I think that's a longer discussion.

Thanks,
Robert