You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/16 15:23:29 UTC
[GitHub] [flink] hehuiyuan opened a new pull request #15244: Fix to create HiveCatalog with custom hadoopconfdir first
hehuiyuan opened a new pull request #15244:
URL: https://github.com/apache/flink/pull/15244
## What is the purpose of the change
There is no prompt when the the path to hadoop conf configured is wrong unintentional.
It is better to load hadoop conf from possiable hadoop path when the path is wrong.
(1) try to load from the custom hadoop conf path
(2) try to load from possiable hadoop conf path if `Configuration hadoopConf` is null.
(3) new Configuration if `Configuration hadoopConf` is null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #15244:
URL: https://github.com/apache/flink/pull/15244#discussion_r596509049
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -224,7 +225,11 @@ private static HiveConf createHiveConf(
} else {
hadoopConf = getHadoopConfiguration(hadoopConfDir);
}
- if (hadoopConf == null) {
+ if (hadoopConf == null && !isNullOrWhitespaceOnly(hadoopConfDir)) {
+ throw new CatalogException(
+ "Failed to load the hadoop conf from specified path:" + hadoopConfDir,
+ new FileNotFoundException("Path " + hadoopConfDir + " does not exist."));
Review comment:
Another situation is `isNullOrWhitespaceOnly` exists but none of the conf files exist in that folder. We should throw exception for that too.
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -224,7 +225,11 @@ private static HiveConf createHiveConf(
} else {
hadoopConf = getHadoopConfiguration(hadoopConfDir);
}
- if (hadoopConf == null) {
+ if (hadoopConf == null && !isNullOrWhitespaceOnly(hadoopConfDir)) {
Review comment:
These can be merged into the above if/else branches. No need to check `isNullOrWhitespaceOnly` again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
}, {
"hash" : "d08636065ad0cc0321115f779ec5134c0593e400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14974",
"triggerID" : "d08636065ad0cc0321115f779ec5134c0593e400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d08636065ad0cc0321115f779ec5134c0593e400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan commented on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-801887684
@flinkbot re-run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan commented on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800901465
@flinkbot test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
}, {
"hash" : "d08636065ad0cc0321115f779ec5134c0593e400",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14974",
"triggerID" : "d08636065ad0cc0321115f779ec5134c0593e400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903)
* d08636065ad0cc0321115f779ec5134c0593e400 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan commented on a change in pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on a change in pull request #15244:
URL: https://github.com/apache/flink/pull/15244#discussion_r595737815
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -212,7 +212,10 @@ private static HiveConf createHiveConf(
@Nullable String hiveConfDir, @Nullable String hadoopConfDir) {
// create HiveConf from hadoop configuration with hadoop conf directory configured.
Configuration hadoopConf = null;
- if (isNullOrWhitespaceOnly(hadoopConfDir)) {
+ if (!isNullOrWhitespaceOnly(hadoopConfDir)) {
+ hadoopConf = getHadoopConfiguration(hadoopConfDir);
+ }
+ if (hadoopConf == null) {
Review comment:
Hi, make some changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan commented on a change in pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on a change in pull request #15244:
URL: https://github.com/apache/flink/pull/15244#discussion_r596826072
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -224,7 +225,11 @@ private static HiveConf createHiveConf(
} else {
hadoopConf = getHadoopConfiguration(hadoopConfDir);
}
- if (hadoopConf == null) {
+ if (hadoopConf == null && !isNullOrWhitespaceOnly(hadoopConfDir)) {
+ throw new CatalogException(
+ "Failed to load the hadoop conf from specified path:" + hadoopConfDir,
+ new FileNotFoundException("Path " + hadoopConfDir + " does not exist."));
Review comment:
@lirui-apache , ok.
Additional, try to find the paths with configuration files as far as possible from possiable hadoop conf path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 739b0d96fc409cee66c3dbe3831afadb9e36dc6d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889)
* 82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 739b0d96fc409cee66c3dbe3831afadb9e36dc6d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835)
* 3fd656a6274d0420241c687e8c742e3b64c89647 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67765b1bdc5e298962438ef9722280697e4a5bb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67765b1bdc5e298962438ef9722280697e4a5bb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881)
* d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889)
* 82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67765b1bdc5e298962438ef9722280697e4a5bb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881)
* d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889)
* 82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
}, {
"hash" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903",
"triggerID" : "82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4",
"triggerType" : "PUSH"
}, {
"hash" : "d08636065ad0cc0321115f779ec5134c0593e400",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d08636065ad0cc0321115f779ec5134c0593e400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82002f03a9cd27b10f37c1bc98ff4a22e60ca4d4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14903)
* d08636065ad0cc0321115f779ec5134c0593e400 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan commented on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800967371
@flinkbot re-run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15244: Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800360956
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 739b0d96fc409cee66c3dbe3831afadb9e36dc6d (Tue Mar 16 15:25:58 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 739b0d96fc409cee66c3dbe3831afadb9e36dc6d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835)
* 3fd656a6274d0420241c687e8c742e3b64c89647 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67765b1bdc5e298962438ef9722280697e4a5bb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881)
* d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan commented on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-801562077
Hi @SteNicholas @lirui-apache
is this OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
}, {
"hash" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889",
"triggerID" : "d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67765b1bdc5e298962438ef9722280697e4a5bb0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14881)
* d9d7e06ea1ea7579e8fc438ebcbf47f6edb9b5d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14889)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hehuiyuan closed pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
hehuiyuan closed pull request #15244:
URL: https://github.com/apache/flink/pull/15244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 739b0d96fc409cee66c3dbe3831afadb9e36dc6d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fd656a6274d0420241c687e8c742e3b64c89647 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 739b0d96fc409cee66c3dbe3831afadb9e36dc6d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #15244:
URL: https://github.com/apache/flink/pull/15244#discussion_r595653041
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -212,7 +212,10 @@ private static HiveConf createHiveConf(
@Nullable String hiveConfDir, @Nullable String hadoopConfDir) {
// create HiveConf from hadoop configuration with hadoop conf directory configured.
Configuration hadoopConf = null;
- if (isNullOrWhitespaceOnly(hadoopConfDir)) {
+ if (!isNullOrWhitespaceOnly(hadoopConfDir)) {
+ hadoopConf = getHadoopConfiguration(hadoopConfDir);
+ }
+ if (hadoopConf == null) {
Review comment:
@hehuiyuan , if the `hadoopConfDir ` has been configured and the `hadoopConf` is null, it should create new `Configuration`. Otherwise, it causes that the `hadoopConfDir` configured looks like correct for the users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15244: [FLINK-21829][Hive Connect]Fix to create HiveCatalog with custom hadoopconfdir first
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15244:
URL: https://github.com/apache/flink/pull/15244#issuecomment-800385093
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14835",
"triggerID" : "739b0d96fc409cee66c3dbe3831afadb9e36dc6d",
"triggerType" : "PUSH"
}, {
"hash" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868",
"triggerID" : "3fd656a6274d0420241c687e8c742e3b64c89647",
"triggerType" : "PUSH"
}, {
"hash" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67765b1bdc5e298962438ef9722280697e4a5bb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fd656a6274d0420241c687e8c742e3b64c89647 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14868)
* 67765b1bdc5e298962438ef9722280697e4a5bb0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org