You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2026/02/28 04:50:01 UTC
[PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
CalvinKirs opened a new pull request, #60903:
URL: https://github.com/apache/doris/pull/60903
…
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3976381049
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #60903:
URL: https://github.com/apache/doris/pull/60903#discussion_r2878719940
##########
be/src/util/s3_util.cpp:
##########
@@ -313,14 +313,9 @@ std::shared_ptr<io::ObjStorageClient> S3ClientFactory::_create_azure_client(
std::make_shared<Azure::Storage::StorageSharedKeyCredential>(s3_conf.ak, s3_conf.sk);
const std::string container_name = s3_conf.bucket;
- std::string uri;
- if (config::force_azure_blob_global_endpoint) {
- uri = fmt::format("https://{}.blob.core.windows.net/{}", s3_conf.ak, container_name);
- } else {
- uri = fmt::format("{}/{}", s3_conf.endpoint, container_name);
- if (s3_conf.endpoint.find("://") == std::string::npos) {
- uri = "https://" + uri;
- }
+ std::string uri = fmt::format("{}/{}", s3_conf.endpoint, container_name);
Review Comment:
If necessary, this should be placed in normalized_uri.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4054812269
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60903_e311685ead3ce240238f104a34a076461018b8ae_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60903_e311685ead3ce240238f104a34a076461018b8ae_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.49% (26211/36663) |
| Line Coverage | 54.27% (274969/506692) |
| Region Coverage | 51.28% (227475/443596) |
| Branch Coverage | 52.84% (98152/185741) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3992280622
# FE Regression Coverage Report
Increment line coverage ` 29.17% (14/48)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60903_38af3c2452cf988d3298c2f895c0d04d357e4241_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60903_38af3c2452cf988d3298c2f895c0d04d357e4241_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4065747995
run cloudut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4053283729
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0aafc42e279ae50a6c61bacedb4d74fe0d58d289_0aafc42e279ae50a6c61bacedb4d74fe0d58d289/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0aafc42e279ae50a6c61bacedb4d74fe0d58d289_0aafc42e279ae50a6c61bacedb4d74fe0d58d289/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.71% (19743/37456) |
| Line Coverage | 36.30% (184542/508398) |
| Region Coverage | 32.41% (142432/439534) |
| Branch Coverage | 33.61% (62255/185249) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3991145945
<details>
<summary>TPC-H: <b>Total hot run time: 29005 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 38af3c2452cf988d3298c2f895c0d04d357e4241, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17635 4460 4323 4323
q2 q3 10637 848 529 529
q4 4713 366 256 256
q5 7822 1216 1008 1008
q6 208 178 148 148
q7 800 864 676 676
q8 10637 1447 1303 1303
q9 5923 4791 4774 4774
q10 6845 1895 1636 1636
q11 462 268 235 235
q12 738 565 469 469
q13 17807 4227 3436 3436
q14 238 236 216 216
q15 949 811 792 792
q16 762 729 690 690
q17 752 899 414 414
q18 6425 5473 5339 5339
q19 1230 978 625 625
q20 570 719 439 439
q21 4637 1934 1425 1425
q22 366 307 272 272
Total cold run time: 100156 ms
Total hot run time: 29005 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4728 4561 4527 4527
q2 q3 1881 2256 1777 1777
q4 865 1176 757 757
q5 4063 4381 4424 4381
q6 191 172 142 142
q7 1773 1679 1531 1531
q8 2524 2768 2655 2655
q9 7478 7387 7671 7387
q10 2602 2799 2429 2429
q11 493 448 521 448
q12 528 607 437 437
q13 3952 4508 3591 3591
q14 285 289 269 269
q15 872 810 795 795
q16 722 789 728 728
q17 1261 1601 1301 1301
q18 7224 6707 6613 6613
q19 885 852 889 852
q20 2095 2206 2026 2026
q21 4014 3484 3348 3348
q22 463 446 382 382
Total cold run time: 48899 ms
Total hot run time: 46376 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #60903:
URL: https://github.com/apache/doris/pull/60903#discussion_r2867115543
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/AzureProperties.java:
##########
@@ -135,7 +135,16 @@ public AzureProperties(Map<String, String> origProps) {
super(Type.AZURE, origProps);
}
- private static final String AZURE_ENDPOINT_SUFFIX = ".blob.core.windows.net";
+ private static final String[] AZURE_ACCOUNT_KEY_ENDPOINTS = {
Review Comment:
why not read from config?
Making it configurable with default list will make it extensible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4053395856
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4053934801
<details>
<summary>TPC-DS: <b>Total hot run time: 170709 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e311685ead3ce240238f104a34a076461018b8ae, data reload: false
query5 4325 673 551 551
query6 337 239 219 219
query7 4217 494 301 301
query8 343 260 245 245
query9 8695 2820 2816 2816
query10 520 415 349 349
query11 7002 5263 4984 4984
query12 192 132 131 131
query13 1270 457 360 360
query14 5572 4091 3810 3810
query14_1 3115 3087 3127 3087
query15 212 200 182 182
query16 983 479 451 451
query17 1113 731 629 629
query18 2453 465 356 356
query19 229 222 190 190
query20 135 130 135 130
query21 221 138 122 122
query22 13490 13536 13508 13508
query23 16018 15622 16048 15622
query23_1 16064 15830 15790 15790
query24 7553 1784 1283 1283
query24_1 1387 1384 1425 1384
query25 608 545 501 501
query26 1445 293 165 165
query27 3188 529 328 328
query28 5139 2050 1993 1993
query29 906 591 484 484
query30 311 241 203 203
query31 1075 984 906 906
query32 81 79 70 70
query33 511 346 302 302
query34 917 928 553 553
query35 681 706 632 632
query36 1101 1137 1023 1023
query37 138 98 85 85
query38 3024 2937 2861 2861
query39 872 853 825 825
query39_1 813 795 805 795
query40 236 157 140 140
query41 67 59 100 59
query42 274 265 259 259
query43 248 259 229 229
query44
query45 216 197 188 188
query46 950 1038 629 629
query47 2510 2123 1975 1975
query48 329 324 249 249
query49 635 486 397 397
query50 736 291 215 215
query51 4149 4180 4103 4103
query52 279 279 265 265
query53 327 355 294 294
query54 310 280 277 277
query55 96 86 84 84
query56 341 334 327 327
query57 1972 1720 1829 1720
query58 294 287 280 280
query59 2892 3001 2772 2772
query60 352 331 320 320
query61 155 153 152 152
query62 652 585 542 542
query63 324 291 289 289
query64 5026 1274 1028 1028
query65
query66 1469 494 372 372
query67 24499 24575 24443 24443
query68
query69 419 327 283 283
query70 1015 997 999 997
query71 360 325 317 317
query72 2794 2768 2439 2439
query73 554 580 324 324
query74 9711 9584 9438 9438
query75 3075 2937 2550 2550
query76 2294 1131 714 714
query77 395 398 314 314
query78 11073 11254 10462 10462
query79 1162 800 603 603
query80 1339 657 576 576
query81 566 279 235 235
query82 1010 158 124 124
query83 340 272 257 257
query84 256 122 105 105
query85 898 484 455 455
query86 420 349 298 298
query87 3216 3150 3020 3020
query88 3628 2712 2673 2673
query89 462 398 377 377
query90 2016 189 188 188
query91 166 164 139 139
query92 76 75 75 75
query93 998 848 502 502
query94 640 321 299 299
query95 590 347 320 320
query96 651 542 233 233
query97 2469 2499 2416 2416
query98 242 229 230 229
query99 1014 981 902 902
Total cold run time: 252696 ms
Total hot run time: 170709 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #60903:
URL: https://github.com/apache/doris/pull/60903#discussion_r2878539397
##########
be/src/util/s3_util.cpp:
##########
@@ -313,14 +313,9 @@ std::shared_ptr<io::ObjStorageClient> S3ClientFactory::_create_azure_client(
std::make_shared<Azure::Storage::StorageSharedKeyCredential>(s3_conf.ak, s3_conf.sk);
const std::string container_name = s3_conf.bucket;
- std::string uri;
- if (config::force_azure_blob_global_endpoint) {
- uri = fmt::format("https://{}.blob.core.windows.net/{}", s3_conf.ak, container_name);
- } else {
- uri = fmt::format("{}/{}", s3_conf.endpoint, container_name);
- if (s3_conf.endpoint.find("://") == std::string::npos) {
- uri = "https://" + uri;
- }
+ std::string uri = fmt::format("{}/{}", s3_conf.endpoint, container_name);
Review Comment:
strip the trailing / of the URI to increase robustness
##########
cloud/src/recycler/s3_accessor.cpp:
##########
@@ -372,13 +372,9 @@ int S3Accessor::init() {
options.Retry.MaxRetries = config::max_s3_client_retry;
auto cred =
std::make_shared<Azure::Storage::StorageSharedKeyCredential>(conf_.ak, conf_.sk);
- if (config::force_azure_blob_global_endpoint) {
- uri_ = fmt::format("https://{}.blob.core.windows.net/{}", conf_.ak, conf_.bucket);
- } else {
- uri_ = fmt::format("{}/{}", conf_.endpoint, conf_.bucket);
- if (uri_.find("://") == std::string::npos) {
- uri_ = "https://" + uri_;
- }
+ uri_ = fmt::format("{}/{}", conf_.endpoint, conf_.bucket);
Review Comment:
ditto
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3544,13 +3544,27 @@ public static int metaServiceRpcRetryTimes() {
public static int s3_head_request_max_paths = 100;
@ConfField(mutable = true, description = {
- "此参数控制是否强制使用 Azure global endpoint。默认值为 false，系统将使用用户指定的 endpoint。"
- + "如果设置为 true，系统将强制使用 {account}.blob.core.windows.net。",
- "This parameter controls whether to force the use of the Azure global endpoint. "
- + "The default is false, meaning the system will use the user-specified endpoint. "
- + "If set to true, the system will force the use of {account}.blob.core.windows.net."
+ "指定 Azure endpoint 域名后缀白名单（包含 blob 与 dfs），多个值使用逗号分隔。"
+ + "默认值为 .blob.core.windows.net,.dfs.core.windows.net,"
+ + ".blob.core.chinacloudapi.cn,.dfs.core.chinacloudapi.cn,"
+ + ".blob.core.usgovcloudapi.net,.dfs.core.usgovcloudapi.net,"
+ + ".blob.core.cloudapi.de,.dfs.core.cloudapi.de。",
+ "The host suffix whitelist for Azure endpoints (both blob and dfs), separated by commas. "
+ + "The default value is .blob.core.windows.net,.dfs.core.windows.net,"
+ + ".blob.core.chinacloudapi.cn,.dfs.core.chinacloudapi.cn,"
+ + ".blob.core.usgovcloudapi.net,.dfs.core.usgovcloudapi.net,"
+ + ".blob.core.cloudapi.de,.dfs.core.cloudapi.de."
})
- public static boolean force_azure_blob_global_endpoint = false;
+ public static String[] azure_blob_host_suffixes = {
+ ".blob.core.windows.net",
Review Comment:
do we need to keep both
.dfs and .blob?
why not sth like just core.winodows.com?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4053880657
<details>
<summary>TPC-H: <b>Total hot run time: 27469 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e311685ead3ce240238f104a34a076461018b8ae, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17631 4524 5309 4524
q2 q3 10637 828 545 545
q4 4674 361 258 258
q5 7595 1195 1024 1024
q6 180 175 148 148
q7 801 844 665 665
q8 9922 1494 1356 1356
q9 5539 4731 4740 4731
q10 6329 1925 1673 1673
q11 466 266 237 237
q12 767 576 474 474
q13 18057 2941 2204 2204
q14 233 228 219 219
q15 q16 748 747 687 687
q17 712 852 443 443
q18 6046 5494 5334 5334
q19 1321 978 663 663
q20 554 480 385 385
q21 4522 2215 1614 1614
q22 364 313 285 285
Total cold run time: 97098 ms
Total hot run time: 27469 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4767 4729 4774 4729
q2 q3 3942 4336 3829 3829
q4 877 1191 789 789
q5 4102 4438 4447 4438
q6 195 202 154 154
q7 1748 1614 1537 1537
q8 2500 2710 2587 2587
q9 7558 7522 7476 7476
q10 3740 3977 3595 3595
q11 521 433 419 419
q12 495 591 510 510
q13 3146 3287 2369 2369
q14 294 309 283 283
q15 q16 739 808 712 712
q17 1162 1385 1311 1311
q18 7262 6860 6769 6769
q19 964 963 957 957
q20 2071 2226 2018 2018
q21 4069 3514 3440 3440
q22 460 420 427 420
Total cold run time: 50612 ms
Total hot run time: 48342 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4065957492
# Cloud UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e311685ead3ce240238f104a34a076461018b8ae_e311685ead3ce240238f104a34a076461018b8ae_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e311685ead3ce240238f104a34a076461018b8ae_e311685ead3ce240238f104a34a076461018b8ae_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.24% (1798/2269) |
| Line Coverage | 64.48% (32288/50072) |
| Region Coverage | 65.41% (16174/24727) |
| Branch Coverage | 55.80% (8612/15434) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3990579589
# Cloud UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/38af3c2452cf988d3298c2f895c0d04d357e4241_38af3c2452cf988d3298c2f895c0d04d357e4241_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/38af3c2452cf988d3298c2f895c0d04d357e4241_38af3c2452cf988d3298c2f895c0d04d357e4241_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.34% (1797/2265) |
| Line Coverage | 64.76% (32182/49694) |
| Region Coverage | 65.65% (16115/24547) |
| Branch Coverage | 56.15% (8586/15292) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3976416461
<details>
<summary>TPC-H: <b>Total hot run time: 28716 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1594b1e59d3a67844c7f8a8ed9b74e9c72d70488, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17604 4510 4312 4312
q2 q3 10644 782 520 520
q4 4675 355 249 249
q5 7549 1195 1021 1021
q6 167 177 147 147
q7 777 842 674 674
q8 9284 1451 1274 1274
q9 4865 4696 4652 4652
q10 6753 1876 1638 1638
q11 435 262 244 244
q12 689 565 473 473
q13 17758 4240 3426 3426
q14 227 238 216 216
q15 907 788 788 788
q16 712 714 681 681
q17 721 872 431 431
q18 5922 5379 5161 5161
q19 1244 990 606 606
q20 515 500 385 385
q21 4920 2025 1551 1551
q22 366 332 267 267
Total cold run time: 96734 ms
Total hot run time: 28716 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4577 4517 4635 4517
q2 q3 1814 2200 1762 1762
q4 916 1209 807 807
q5 4022 4304 4339 4304
q6 209 181 141 141
q7 1782 1628 1496 1496
q8 2581 2670 2570 2570
q9 7473 7247 7572 7247
q10 2636 2827 2424 2424
q11 512 447 414 414
q12 522 584 450 450
q13 3965 4365 3630 3630
q14 283 317 314 314
q15 900 837 822 822
q16 730 770 697 697
q17 1207 1534 1283 1283
q18 7016 6648 6759 6648
q19 888 899 932 899
q20 2108 2206 2149 2149
q21 3928 3451 3372 3372
q22 468 425 378 378
Total cold run time: 48537 ms
Total hot run time: 46324 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3992215442
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60903_38af3c2452cf988d3298c2f895c0d04d357e4241_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60903_38af3c2452cf988d3298c2f895c0d04d357e4241_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.57% (26176/36576) |
| Line Coverage | 54.39% (274678/504998) |
| Region Coverage | 51.88% (229233/441880) |
| Branch Coverage | 53.07% (98174/185002) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3990374309
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4054570765
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e311685ead3ce240238f104a34a076461018b8ae_e311685ead3ce240238f104a34a076461018b8ae/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e311685ead3ce240238f104a34a076461018b8ae_e311685ead3ce240238f104a34a076461018b8ae/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.66% (19726/37458) |
| Line Coverage | 36.24% (184252/508414) |
| Region Coverage | 32.41% (142452/439548) |
| Branch Coverage | 33.57% (62199/185259) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3976431295
<details>
<summary>TPC-DS: <b>Total hot run time: 183370 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1594b1e59d3a67844c7f8a8ed9b74e9c72d70488, data reload: false
query5 5646 649 522 522
query6 328 217 204 204
query7 4216 458 263 263
query8 341 236 227 227
query9 8755 2750 2707 2707
query10 537 382 330 330
query11 16879 17479 16961 16961
query12 209 134 120 120
query13 1362 477 353 353
query14 8349 3339 3082 3082
query14_1 2989 2944 2953 2944
query15 214 197 181 181
query16 1057 418 491 418
query17 1527 775 653 653
query18 2750 448 348 348
query19 223 210 185 185
query20 139 128 137 128
query21 230 135 117 117
query22 4754 5033 4755 4755
query23 17205 16863 16558 16558
query23_1 16571 16707 16716 16707
query24 6786 1620 1220 1220
query24_1 1221 1218 1232 1218
query25 564 488 459 459
query26 1239 255 145 145
query27 2759 459 279 279
query28 4529 1875 1853 1853
query29 777 553 468 468
query30 313 255 210 210
query31 847 728 641 641
query32 80 69 69 69
query33 504 329 283 283
query34 903 907 565 565
query35 625 676 593 593
query36 1073 1090 985 985
query37 141 90 86 86
query38 2969 2920 2865 2865
query39 871 891 854 854
query39_1 846 827 829 827
query40 233 151 133 133
query41 61 59 58 58
query42 107 105 104 104
query43 371 383 362 362
query44
query45 201 189 181 181
query46 875 985 601 601
query47 2101 2133 2049 2049
query48 312 321 235 235
query49 626 453 381 381
query50 673 284 215 215
query51 4107 4131 4051 4051
query52 105 106 98 98
query53 294 326 283 283
query54 302 263 251 251
query55 93 84 78 78
query56 313 300 321 300
query57 1348 1328 1248 1248
query58 291 274 275 274
query59 2613 2721 2558 2558
query60 341 329 323 323
query61 149 145 144 144
query62 626 584 547 547
query63 313 277 272 272
query64 4828 1261 983 983
query65
query66 1368 445 374 374
query67 16318 16364 16385 16364
query68
query69 394 304 302 302
query70 958 955 972 955
query71 331 310 295 295
query72 2773 2602 2398 2398
query73 541 543 327 327
query74 10023 9930 9792 9792
query75 2862 2736 2440 2440
query76 2250 1038 672 672
query77 366 385 335 335
query78 11283 11481 10751 10751
query79 1167 792 601 601
query80 1388 609 543 543
query81 556 289 246 246
query82 1005 147 116 116
query83 339 257 245 245
query84 252 111 102 102
query85 906 485 425 425
query86 461 309 296 296
query87 3124 3086 3039 3039
query88 3508 2686 2658 2658
query89 426 366 350 350
query90 1952 177 175 175
query91 161 157 132 132
query92 78 71 72 71
query93 990 823 504 504
query94 644 314 280 280
query95 561 411 314 314
query96 623 526 227 227
query97 2476 2479 2395 2395
query98 233 221 214 214
query99 1017 979 915 915
Total cold run time: 255415 ms
Total hot run time: 183370 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4064702677
run cloud_ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3990153009
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3991213728
<details>
<summary>TPC-DS: <b>Total hot run time: 184631 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 38af3c2452cf988d3298c2f895c0d04d357e4241, data reload: false
query5 4320 660 521 521
query6 333 223 250 223
query7 4217 489 292 292
query8 357 248 241 241
query9 8754 2787 2769 2769
query10 487 389 364 364
query11 16972 17439 17410 17410
query12 200 150 132 132
query13 1521 484 357 357
query14 6811 3392 3190 3190
query14_1 2967 2999 2976 2976
query15 208 214 208 208
query16 998 512 483 483
query17 1219 766 660 660
query18 2739 486 357 357
query19 229 223 193 193
query20 144 137 134 134
query21 221 150 128 128
query22 5754 5612 5091 5091
query23 17334 16854 16538 16538
query23_1 16763 16767 16723 16723
query24 7184 1628 1242 1242
query24_1 1237 1248 1243 1243
query25 567 480 438 438
query26 1242 264 159 159
query27 2743 473 333 333
query28 4450 1867 1889 1867
query29 772 574 470 470
query30 306 251 212 212
query31 874 745 657 657
query32 83 76 71 71
query33 512 345 276 276
query34 935 914 569 569
query35 630 697 594 594
query36 1079 1129 982 982
query37 138 95 89 89
query38 2958 2913 2854 2854
query39 879 868 860 860
query39_1 821 814 808 808
query40 238 156 133 133
query41 65 60 60 60
query42 105 102 102 102
query43 376 381 357 357
query44
query45 195 189 187 187
query46 886 987 622 622
query47 2142 2122 2068 2068
query48 315 335 247 247
query49 630 465 386 386
query50 690 268 220 220
query51 4135 4117 4015 4015
query52 109 109 98 98
query53 298 341 292 292
query54 331 269 265 265
query55 88 87 87 87
query56 324 311 325 311
query57 1377 1334 1274 1274
query58 298 276 289 276
query59 2559 2629 2525 2525
query60 353 345 331 331
query61 161 150 153 150
query62 641 599 540 540
query63 316 276 278 276
query64 4914 1278 1012 1012
query65
query66 1426 459 356 356
query67 16475 16458 16291 16291
query68
query69 409 313 292 292
query70 1005 961 943 943
query71 353 305 306 305
query72 2818 2652 2461 2461
query73 563 555 318 318
query74 9942 10000 9706 9706
query75 2863 2785 2464 2464
query76 2291 1037 673 673
query77 367 389 314 314
query78 11148 11376 10650 10650
query79 2939 827 591 591
query80 1798 645 592 592
query81 572 278 246 246
query82 997 145 116 116
query83 331 264 242 242
query84 251 121 100 100
query85 895 472 430 430
query86 406 330 303 303
query87 3103 3085 2985 2985
query88 3538 2660 2642 2642
query89 442 383 343 343
query90 2020 181 173 173
query91 167 161 133 133
query92 89 80 70 70
query93 1338 847 507 507
query94 649 328 296 296
query95 594 391 311 311
query96 658 533 233 233
query97 2498 2485 2398 2398
query98 240 224 226 224
query99 997 1000 919 919
Total cold run time: 257048 ms
Total hot run time: 184631 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4052228590
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs merged PR #60903:
URL: https://github.com/apache/doris/pull/60903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3976379796
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3991191102
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #60903:
URL: https://github.com/apache/doris/pull/60903#discussion_r2878653959
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3544,13 +3544,27 @@ public static int metaServiceRpcRetryTimes() {
public static int s3_head_request_max_paths = 100;
@ConfField(mutable = true, description = {
- "此参数控制是否强制使用 Azure global endpoint。默认值为 false，系统将使用用户指定的 endpoint。"
- + "如果设置为 true，系统将强制使用 {account}.blob.core.windows.net。",
- "This parameter controls whether to force the use of the Azure global endpoint. "
- + "The default is false, meaning the system will use the user-specified endpoint. "
- + "If set to true, the system will force the use of {account}.blob.core.windows.net."
+ "指定 Azure endpoint 域名后缀白名单（包含 blob 与 dfs），多个值使用逗号分隔。"
+ + "默认值为 .blob.core.windows.net,.dfs.core.windows.net,"
+ + ".blob.core.chinacloudapi.cn,.dfs.core.chinacloudapi.cn,"
+ + ".blob.core.usgovcloudapi.net,.dfs.core.usgovcloudapi.net,"
+ + ".blob.core.cloudapi.de,.dfs.core.cloudapi.de。",
+ "The host suffix whitelist for Azure endpoints (both blob and dfs), separated by commas. "
+ + "The default value is .blob.core.windows.net,.dfs.core.windows.net,"
+ + ".blob.core.chinacloudapi.cn,.dfs.core.chinacloudapi.cn,"
+ + ".blob.core.usgovcloudapi.net,.dfs.core.usgovcloudapi.net,"
+ + ".blob.core.cloudapi.de,.dfs.core.cloudapi.de."
})
- public static boolean force_azure_blob_global_endpoint = false;
+ public static String[] azure_blob_host_suffixes = {
+ ".blob.core.windows.net",
Review Comment:
This is required by the HDFS style guidelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4065978104
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3990735029
# FE UT Coverage Report
Increment line coverage ` 64.58% (31/48)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60903_38af3c2452cf988d3298c2f895c0d04d357e4241/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60903_38af3c2452cf988d3298c2f895c0d04d357e4241/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3991769862
# BE UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/38af3c2452cf988d3298c2f895c0d04d357e4241_38af3c2452cf988d3298c2f895c0d04d357e4241/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/38af3c2452cf988d3298c2f895c0d04d357e4241_38af3c2452cf988d3298c2f895c0d04d357e4241/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.58% (19642/37354) |
| Line Coverage | 36.22% (183468/506551) |
| Region Coverage | 32.49% (142235/437743) |
| Branch Coverage | 33.45% (61696/184438) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3991191387
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-4052428035
# Cloud UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0aafc42e279ae50a6c61bacedb4d74fe0d58d289_0aafc42e279ae50a6c61bacedb4d74fe0d58d289_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0aafc42e279ae50a6c61bacedb4d74fe0d58d289_0aafc42e279ae50a6c61bacedb4d74fe0d58d289_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.24% (1798/2269) |
| Line Coverage | 64.55% (32288/50022) |
| Region Coverage | 65.42% (16159/24699) |
| Branch Coverage | 55.88% (8613/15414) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Azure)Fix Azure endpoint detection for sovereign clouds with force-global config support [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #60903:
URL: https://github.com/apache/doris/pull/60903#issuecomment-3976379857
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org