You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2022/07/02 03:13:35 UTC

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#10).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 35 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>