[PR] Support Oracle bare CROSSEDITION trigger and XMLForest alias without AS from issue #27073 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #39570:
URL: https://github.com/apache/shardingsphere/pull/39570

   - Make FORWARD/REVERSE optional in triggerEditionClause, since Oracle documents FORWARD as the default crossedition form
   - Accept alias without AS in exprWithAlias and xmlAsAliasOrEvalnameExpr for XMLATTRIBUTES, XMLELEMENT, XMLFOREST and XMLCOLATTVAL parameters
   - Add parser IT cases for the CREATE OR REPLACE trigger statements and XMLFOREST alias from the issue
   
   Fixes #27073
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support Oracle bare CROSSEDITION trigger and XMLForest alias without AS from issue #27073 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39570:
URL: https://github.com/apache/shardingsphere/pull/39570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support Oracle bare CROSSEDITION trigger and XMLForest alias without AS from issue #27073 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #39570:
URL: https://github.com/apache/shardingsphere/pull/39570#issuecomment-5383955264

   ### Result
   
   **Review Result: Mergeable**
   
   The second commit cleanly resolves the CI-blocking stale PostgreSQL CTAS unsupported-SQL cases inherited from base #39569, and the original Oracle grammar relaxations remain pure supersets with full IT coverage; fresh verification at the new head is green.
   
   ### Evidence
   
   - New head `e16f63a72ea026f1c84d617ceace1d0ad48320aa` (2 commits over base `d9121e8872`); local HEAD equals the public head with a clean worktree, and the local triple-dot file list matches the authoritative GitHub list exactly (7/7).
   - Latest delta (commit 2): `test/it/parser/src/main/resources/sql/unsupported/unsupported.xml` removes exactly the two stale PostgreSQL CTAS cases `create_table_as_select` and `create_temp_table`. Root cause verified: base commit #39569 added PostgreSQL CREATE TABLE AS SELECT parsing ("Fix PostgreSQL createTable grammar so column definitions are optional for CTAS") but left these cases in the unsupported registry, so `InternalUnsupportedPostgreSQLParserIT` failed 4 parameters (2 cases x LITERAL/PLACEHOLDER) with "Expected SQLParsingException to be thrown, but nothing was thrown". The same syntax family is already protected by supported cases `create_table_pg_as_select` and `create_table_pg_temp_as_select_with_no_data` added in #39569, and the same-ID `create_table_as_select` in `sql/supported/ddl/create-table.xml:146` is an independent SQLServer case in a separate registry, so removal is safe with no dangling references.
   - Oracle grammar relaxations unchanged from the previously verified commit and still evidence-backed: `parser/sql/engine/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4:753` (`(FORWARD | REVERSE)? CROSSEDITION`, per Oracle PL/SQL Language Reference 19c trigger_edition_clause semantics where FORWARD is the default) and `BaseRule.g4:1785`/`BaseRule.g4:1805` (optional AS, per Oracle SQL Reference 19c XMLFOREST where the AS clause is omissible).
   - Fresh runtime verification at the new head (`./mvnw -pl test/it/parser clean test -Dtest=...oracle.InternalOracleParserIT,...postgresql.InternalUnsupportedPostgreSQLParserIT`, exit 0): InternalOracleParserIT Tests run: 1920, Failures: 0; InternalUnsupportedPostgreSQLParserIT Tests run: 12, Failures: 0. The initially observed combined-run compile error was stale local `target/classes` state (source present, compiled class missing) and disappeared after `clean`; it is an environment artifact, not a PR defect.
   
   ### Coverage
   
   - Reviewed head `e16f63a72ea026f1c84d617ceace1d0ad48320aa`; authoritative requirements: PR #39570 description and linked issue #27073 (both previously failing SQLs fixed, remaining three already parsed); all 7 authoritative files accounted for with no churn-only files.
   - Behavior clusters (4): triggerEditionClause relaxation (PLSQL.g4), XML function alias relaxation (BaseRule.g4), parser IT cases (4 resource files), stale unsupported-case removal (unsupported.xml). Dialect check: Oracle is a trunk dialect with no branch databases; PostgreSQL engine files untouched by this PR; the removed cases are PostgreSQL-tagged only.
   - All three discovery lenses completed with a full-scope convergence pass after the latest commit; zero candidates passed the Finding Proof Gate. Multi-round classification: no prior public findings existed; the unsupported.xml change is verified as a base-inherited fix, not a new issue. Ledger validated with all files, clusters, risk axes, and passes recorded, then removed.
   - Residual note (non-blocking): master HEAD `d9121e8872` itself carries the same unsupported-IT failure (no push-triggered CI exists), and merging this PR repairs it; the duplicate first-line commit messages across the two commits are cosmetic only.
   - This is a Code Correctness Review; the result is code-scope only and CI/Actions state was not queried or reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org