You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/09 01:27:39 UTC
[GitHub] [ignite] Nikita-tech-writer opened a new pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Nikita-tech-writer opened a new pull request #8776:
URL: https://github.com/apache/ignite/pull/8776
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#issuecomment-787940744
I've applied all the suggested changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#issuecomment-787971330
@Mmuzaf Hi Maxim! Could you please cherry-pick this improvement to the 2.10 documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tkalkirill commented on a change in pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on a change in pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#discussion_r573670223
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
+. `IndexBuildCountPartitionsLeft` - gives the remaining number of partitions (by cache group) to rebuild indexes for
Review comment:
The **for** at the end is superfluous.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
Review comment:
Whether indexes are being built or rebuilt right now.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
Review comment:
I would say: Monitoring build and rebuild indexes.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
+. `IndexBuildCountPartitionsLeft` - gives the remaining number of partitions (by cache group) to rebuild indexes for
+
+These metrics allow to estimate an approximate number of indexes left to rebuild.
+For a more accurate estimate, use the `IndexRebuildKeyProcessed` cache metric:
+
+* Use `org.apache.ignite.mxbean.CacheMetricsMXBean#isIndexRebuildInProgress` to know whether the indexes are being rebuilt for the cache.
+Note that presently only the `org.apache.ignite.internal.processors.cache.CacheLocalMetricsMXBeanImpl#isIndexRebuildInProgress` local metric is available.
+
+* Use `org.apache.ignite.mxbean.CacheMetricsMXBean#getIndexRebuildKeysProcessed` to know the number of indexes that are rebuilt for the cache. If the rebuilding is in progress, it gives a number of indexes being rebuilt at the current moment. Otherwise, it gives a total number of the rebuilt indexes. The values are reset before the start of each rebuilding.
Review comment:
Not the number of indexes, but the number of keys for which all their indexes have been rebuilt.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
+. `IndexBuildCountPartitionsLeft` - gives the remaining number of partitions (by cache group) to rebuild indexes for
+
+These metrics allow to estimate an approximate number of indexes left to rebuild.
Review comment:
It seems that it can only be said about the **IndexBuildCountPartitionsLeft** that it gives little information. And about the **IsIndexRebuildInProgress** just say below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf merged pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8776:
URL: https://github.com/apache/ignite/pull/8776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#issuecomment-789689870
> @Nikita-tech-writer
>
> Can you also update the `IndexRebuildKeyProcessed` and `IsIndexRebuildInProgress` description at the `new-metrics.adoc` page?
@Mmuzaf Done:
[1] https://issues.apache.org/jira/browse/IGNITE-14271
[2] https://github.com/apache/ignite/pull/8848/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#issuecomment-775585100
@tkalkirill Please take a look at the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#issuecomment-788117517
@Nikita-tech-writer
Can you also update the `IndexRebuildKeyProcessed` and `IsIndexRebuildInProgress` description at the `new-metrics.adoc` page?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8776: IGNITE-14143 Document metric for processed keys when rebuilding indexes.
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8776:
URL: https://github.com/apache/ignite/pull/8776#discussion_r584732776
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
Review comment:
Fixed.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
Review comment:
Fixed.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
+. `IndexBuildCountPartitionsLeft` - gives the remaining number of partitions (by cache group) to rebuild indexes for
Review comment:
Fixed.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
+. `IndexBuildCountPartitionsLeft` - gives the remaining number of partitions (by cache group) to rebuild indexes for
+
+These metrics allow to estimate an approximate number of indexes left to rebuild.
Review comment:
Fixed.
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -308,6 +308,22 @@ group=<Cache Name>,name="org.apache.ignite.internal.processors.cache.CacheLocalM
|===
--
+=== Monitoring Processed Keys for Rebuilding Indexes
+
+To get an estimate on how long it takes to rebuild cache indexes, you can use one of the metrics listed below:
+
+. `IsIndexRebuildInProgress` - gives the number of currently rebuilding cache indexes
+. `IndexBuildCountPartitionsLeft` - gives the remaining number of partitions (by cache group) to rebuild indexes for
+
+These metrics allow to estimate an approximate number of indexes left to rebuild.
+For a more accurate estimate, use the `IndexRebuildKeyProcessed` cache metric:
+
+* Use `org.apache.ignite.mxbean.CacheMetricsMXBean#isIndexRebuildInProgress` to know whether the indexes are being rebuilt for the cache.
+Note that presently only the `org.apache.ignite.internal.processors.cache.CacheLocalMetricsMXBeanImpl#isIndexRebuildInProgress` local metric is available.
+
+* Use `org.apache.ignite.mxbean.CacheMetricsMXBean#getIndexRebuildKeysProcessed` to know the number of indexes that are rebuilt for the cache. If the rebuilding is in progress, it gives a number of indexes being rebuilt at the current moment. Otherwise, it gives a total number of the rebuilt indexes. The values are reset before the start of each rebuilding.
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org