You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/02/08 03:24:01 UTC

[GitHub] [servicecomb-service-center] DFSOrange opened a new pull request #851: add mongo init script

DFSOrange opened a new pull request #851:
URL: https://github.com/apache/servicecomb-service-center/pull/851


   1. add mongo db init script
   2. print err info when mongo init failed
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #851: add mongo init script

Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #851:
URL: https://github.com/apache/servicecomb-service-center/pull/851


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #851: add mongo init script

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #851:
URL: https://github.com/apache/servicecomb-service-center/pull/851#issuecomment-774900061


   请给个初始化指导，另外初始化脚本应该放在deployments下面


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #851: add mongo init script

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #851:
URL: https://github.com/apache/servicecomb-service-center/pull/851#discussion_r571803190



##########
File path: datasource/mongo/client/mongo.go
##########
@@ -128,6 +128,7 @@ func (mc *MongoClient) newClient(ctx context.Context) (err error) {
 	clientOptions := options.Client().ApplyURI(mc.dbconfig.URI)
 	mc.client, err = mongo.Connect(ctx, clientOptions)
 	if err != nil {
+		log.Error("[init mongo client] failed to connect to mongo", err)

Review comment:
       没必要中括号和里面内容




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org