[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7253: Core: Fix flakiness in HadoopFileIOTest

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7253:
URL: https://github.com/apache/iceberg/pull/7253#discussion_r1157550694


##########
core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java:
##########
@@ -166,6 +170,8 @@ public void testHadoopFileIOJavaSerialization() throws IOException, ClassNotFoun
 
   private List<Path> createRandomFiles(Path parent, int count) {
     List<Path> paths = Lists.newArrayList();

Review Comment:
   I think the underlying error here is using an arrayList in a multi threaded context. I switched this with a Vector implementation and so far have run the "testDeleteFiles" test 12,000 times without error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org