You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/02/08 16:40:45 UTC

[GitHub] flink pull request #5434: [FLINK-8611] [flip6] Add result future to JobManag...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5434

    [FLINK-8611] [flip6] Add result future to JobManagerRunner

    ## What is the purpose of the change
    
    This commit adds a CompletableFuture<ArchivedExecutionGraph> to the
    JobManagerRunner. This future will be completed once the job has
    reached a globally terminal state.
    
    This PR is based on #5431.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink jobManagerRunnerFuture

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5434
    
----
commit db57b574b0a2bacfa5aa164082c1eeb8f5258ed8
Author: Till Rohrmann <tr...@...>
Date:   2018-02-08T13:34:54Z

    [FLINK-8608] [flip6] Implement MiniDispatcher for job mode
    
    The MiniDispatcher is responsible for submitting the single job with which
    a job mode cluster is started. Once the job has completed and if the cluster
    has been started in detached mode, the MiniDispatcher will terminate.
    
    In order to reduce code duplication, the MiniDispatcher is a sub class of the
    Dispatcher which is started with a single job submitted job graph store.

commit d9af78da8eec870eb8fcce140ce13b2c06ca4e5d
Author: Till Rohrmann <tr...@...>
Date:   2018-02-07T13:12:54Z

    [hotfix] Fix checkstyle violations in JobExecutionResult

commit 3c414687bc73229f045d861d57da3843ca470469
Author: Till Rohrmann <tr...@...>
Date:   2018-02-07T13:56:45Z

    [FLINK-8611] [flip6] Add result future to JobManagerRunner
    
    This commit adds a CompletableFuture<ArchivedExecutionGraph> to the
    JobManagerRunner. This future will be completed once the job has
    reached a globally terminal state.

----


---

[GitHub] flink pull request #5434: [FLINK-8611] [flip6] Add result future to JobManag...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5434


---

[GitHub] flink issue #5434: [FLINK-8611] [flip6] Add result future to JobManagerRunne...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5434
  
    Rebased onto the soon to be master.


---