You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/10 05:58:27 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #11497: Use equals instead of == to compare strings (#11462)
eolivelli commented on a change in pull request #11497:
URL: https://github.com/apache/pulsar/pull/11497#discussion_r685711727
##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarColumnMetadata.java
##########
@@ -187,7 +188,7 @@ public boolean equals(Object o) {
DecoderExtraInfo that = (DecoderExtraInfo) o;
- if (mapping != that.mapping) {
+ if (!StringUtils.equals(mapping, that.mapping)) {
Review comment:
no need to use a third party library for this.
we can use `Object.equals(mapping, that.mapping)`
##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java
##########
@@ -116,7 +116,7 @@ public void startServer(String path) throws Exception {
// create a zookeeper client
LOG.debug("Instantiate ZK Client");
zkc = ZooKeeperClient.newBuilder().connectString(getZooKeeperConnectString()).build();
- if (path != "") {
+ if (StringUtils.isNotEmpty(path)) {
Review comment:
`if (!path.isEmpty()) ` is enough here, no need to use a third party library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org