You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/29 02:03:08 UTC

[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation

JackieTien97 commented on a change in pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#discussion_r738879693



##########
File path: server/src/main/java/org/apache/iotdb/db/query/aggregation/impl/SumAggrResult.java
##########
@@ -37,28 +37,40 @@
 public class SumAggrResult extends AggregateResult {
 
   private TSDataType seriesDataType;
+  private double sum;
+  private boolean notNull;

Review comment:
       I think these two fields are unnecessary. You can use `doubleValue` and `hasCandidateResult` in `AggregateResult `




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org