You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2014/12/23 12:45:26 UTC
Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/
-----------------------------------------------------------
Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
Bugs: LENS-112
https://issues.apache.org/jira/browse/LENS-112
Repository: lens
Description
-------
Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
Diffs
-----
src/site/apt/developer/commit.apt 7067c2b
src/site/apt/developer/contribute.apt 87ab46b
Diff: https://reviews.apache.org/r/29362/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 24, 2014, 4:02 a.m., Srikanth Sundarrajan wrote:
> > src/site/apt/developer/contribute.apt, line 41
> > <https://reviews.apache.org/r/29362/diff/1/?file=799441#file799441line41>
> >
> > Though seems miscellaneous, I think this one is not easy for a new comer or a person who is less involved with the project
Agreed. But this does not say it is from a new comer. This can be done by anyone
> On Dec. 24, 2014, 4:02 a.m., Srikanth Sundarrajan wrote:
> > src/site/apt/developer/contribute.apt, line 52
> > <https://reviews.apache.org/r/29362/diff/1/?file=799441#file799441line52>
> >
> > Adding tests is often a good way to learn the system and we should welcome contributions on that front as well.
Yes. This is added as part of quality improvements, not in miscellaneous
> On Dec. 24, 2014, 4:02 a.m., Srikanth Sundarrajan wrote:
> > src/site/apt/developer/contribute.apt, line 63
> > <https://reviews.apache.org/r/29362/diff/1/?file=799441#file799441line63>
> >
> > Is the delay in mirroring noticeable ?
Yes. I was seeing few minutes and more on some days
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review66002
-----------------------------------------------------------
On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:05 p.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review66002
-----------------------------------------------------------
src/site/apt/developer/commit.apt
<https://reviews.apache.org/r/29362/#comment109320>
updated earliest*
src/site/apt/developer/commit.apt
<https://reviews.apache.org/r/29362/#comment109321>
Why are these removed. Seems relevant. Moved elsewhere?
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109322>
Remove "Trying to list them here". "following" in the ealier part seems to indicate the same.
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109323>
Though seems miscellaneous, I think this one is not easy for a new comer or a person who is less involved with the project
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109324>
Adding tests is often a good way to learn the system and we should welcome contributions on that front as well.
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109325>
Is the delay in mirroring noticeable ?
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109326>
"then this is not the place to go" should perhaps be "then this is not the place to add them"
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109327>
Ah!. It looks like the review guidelines have simply been moved. thanks
src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/29362/#comment109328>
Some of this is repeat of what is mentioned in DeveloperMenu (perhaps it need to be removed from there)
- Srikanth Sundarrajan
On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:05 p.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Dec. 23, 2014, 12:12 p.m., Jaideep dhok wrote:
> > src/site/apt/developer/commit.apt, line 79
> > <https://reviews.apache.org/r/29362/diff/1/?file=799440#file799440line79>
> >
> > Does the person committing also has to rerun all tests? Or is it onus of the person submitting the patch?
Committer can ask the contributor to update the test result he ran. Only thing we want to ensure is no tests are broken. Once we have jenkins builds for testing patch available jiras, this should be easy.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review65929
-----------------------------------------------------------
On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:05 p.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review65929
-----------------------------------------------------------
src/site/apt/developer/commit.apt
<https://reviews.apache.org/r/29362/#comment109206>
Does the person committing also has to rerun all tests? Or is it onus of the person submitting the patch?
- Jaideep dhok
On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:05 p.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review65934
-----------------------------------------------------------
Ship it!
Ship It!
- Jaideep dhok
On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:05 p.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review66003
-----------------------------------------------------------
src/site/apt/developer/commit.apt
<https://reviews.apache.org/r/29362/#comment109330>
seems moved to review section
- Raju Bairishetti
On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:05 p.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/#review66033
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Dec. 24, 2014, 5:54 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29362/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 5:54 a.m.)
>
>
> Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
>
>
> Bugs: LENS-112
> https://issues.apache.org/jira/browse/LENS-112
>
>
> Repository: lens
>
>
> Description
> -------
>
> Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 7067c2b
> src/site/apt/developer/contribute.apt 87ab46b
>
> Diff: https://reviews.apache.org/r/29362/diff/
>
>
> Testing
> -------
>
> Validated the doc by running in local. Verified all links work fine.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 5:54 a.m.)
Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
Bugs: LENS-112
https://issues.apache.org/jira/browse/LENS-112
Repository: lens
Description
-------
Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
Diffs
-----
src/site/apt/developer/commit.apt 7067c2b
src/site/apt/developer/contribute.apt 87ab46b
Diff: https://reviews.apache.org/r/29362/diff/
Testing
-------
Validated the doc by running in local. Verified all links work fine.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 5:53 a.m.)
Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
Changes
-------
Incorporated review comments
Bugs: LENS-112
https://issues.apache.org/jira/browse/LENS-112
Repository: lens
Description
-------
Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
Diffs (updated)
-----
src/site/apt/developer/commit.apt 7067c2b
src/site/apt/developer/contribute.apt 87ab46b
Diff: https://reviews.apache.org/r/29362/diff/
Testing
-------
Validated the doc by running in local. Verified all links work fine.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 29362: LENS-112 Improve contributor doc with more
guidelines
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29362/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 12:05 p.m.)
Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, and Suma Shivaprasad.
Bugs: LENS-112
https://issues.apache.org/jira/browse/LENS-112
Repository: lens
Description
-------
Improves contributor doc by adding guidelines for miscellaneous contributions, quality improvements, documentation guidelines and reviewing guidelines.
Diffs
-----
src/site/apt/developer/commit.apt 7067c2b
src/site/apt/developer/contribute.apt 87ab46b
Diff: https://reviews.apache.org/r/29362/diff/
Testing (updated)
-------
Validated the doc by running in local. Verified all links work fine.
Thanks,
Amareshwari Sriramadasu