You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/11/30 20:06:32 UTC

[Bug 6242] New: Recognize MS Exchange HTTP-DAV message submission

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

           Summary: Recognize MS Exchange HTTP-DAV message submission
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: dot@dotat.at


Created an attachment (id=4580)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4580)
proposed patch

Yet another Received: header pattern...

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

--- Comment #4 from Daryl C. W. O'Shea <sp...@dostech.ca> 2009-12-03 16:51:56 UTC ---
+1

Minor nit, for commit, I'd use another elsif, rather than a new if block.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Tony Finch <do...@dotat.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dot@dotat.at

--- Comment #7 from Tony Finch <do...@dotat.at> 2009-12-07 06:58:13 UTC ---
Thanks for the reviews everyone. Fix committed to trunk in rev 887941.

Should I backport to 3.3 and 3.2?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.3.0

--- Comment #8 from Justin Mason <jm...@jmason.org> 2009-12-07 07:26:57 UTC ---
we haven't actually branched 3.3.0 yet, so no need for that.  you can aim at
3.2.x but I think it's unlikely we'll be doing another maintainance release
there....

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Tony Finch <do...@dotat.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
         AssignedTo|dev@spamassassin.apache.org |dot@dotat.at

--- Comment #10 from Tony Finch <do...@dotat.at> 2010-03-31 13:39:12 UTC ---
Created an attachment (id=4728)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4728)
fix http-dav regex

Ooops.

This code fails to match (some? all?) HTTP-DAV Received: headers if the "with
..." part comes immediately before the date part, because the date and any
preceding whitespace and semicolons are stripped. For example (wrapped by me):

Received: from 81.107.35.91 ([81.107.35.91])
 by silicon.mrc-epid.cam.ac.uk ([131.111.251.141])
 via Exchange Front-End Server webmail.mrc-epid.cam.ac.uk ([131.111.251.150])
 with Microsoft Exchange Server HTTP-DAV ; Tue, 30 Mar 2010 18:48:48 +0000

The trailing space in the regex fails to match in this instance.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Tony Finch <do...@dotat.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Tony Finch <do...@dotat.at> 2009-12-07 08:02:57 UTC ---
OK I'll leave it at that.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: [Bug 6242] New: Recognize MS Exchange HTTP-DAV message submission

Posted by Tony Finch <do...@dotat.at>.
On Mon, 30 Nov 2009, bugzilla-daemon@bugzilla.spamassassin.org wrote:
>
> Created an attachment (id=4580)
>  --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4580)
> proposed patch
>
> Yet another Received: header pattern...

Do we currently need review for patches or should I go ahead and commit?

Tony.
-- 
f.anthony.n.finch  <do...@dotat.at>  http://dotat.at/
GERMAN BIGHT HUMBER: SOUTHWEST 5 TO 7. MODERATE OR ROUGH. SQUALLY SHOWERS.
MODERATE OR GOOD.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

--- Comment #2 from Tony Finch <do...@dotat.at> 2009-12-02 05:24:56 UTC ---
Created an attachment (id=4583)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4583)
patch modified to omit space

OK, here's a trivially simplified version...

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jm@jmason.org

--- Comment #6 from Justin Mason <jm...@jmason.org> 2009-12-06 13:06:21 UTC ---
+1 with an elsif

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Tony Finch <do...@dotat.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4583|0                           |1
        is obsolete|                            |

--- Comment #3 from Tony Finch <do...@dotat.at> 2009-12-03 09:31:04 UTC ---
Created an attachment (id=4584)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4584)
add missing curly brace

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Tony Finch <do...@dotat.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4580|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #4580|0                           |1
           is patch|                            |
   Attachment #4580|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

Daryl C. W. O'Shea <sp...@dostech.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spamassassin@dostech.ca

--- Comment #1 from Daryl C. W. O'Shea <sp...@dostech.ca> 2009-12-01 19:00:22 UTC ---
-0.9 on patch 4850.  I'm pretty sure that the $auth value can't have spaces. 
No other "rcvd_parser field values" have spaces, IIRC.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6242] Recognize MS Exchange HTTP-DAV message submission

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6242

--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2009-12-05 17:58:35 UTC ---
(In reply to comment #4)
> +1 
> Minor nit, for commit, I'd use another elsif, rather than a new if block.

+1, using elsif

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.