You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/24 02:35:39 UTC
Review Request 13789: Exposed recovery errors that are encountered in
non-strict recovery mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13789/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.
Bugs: MESOS-663
https://issues.apache.org/jira/browse/MESOS-663
Repository: mesos-git
Description
-------
Number of recovery errors ignored while in non-strict mode are now exposed.
Diffs
-----
src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316
src/slave/slave.hpp aca7f031fb987d1c522c634680dd2c56623b4753
src/slave/slave.cpp 563a0997b1fec7c827bd6950c449fa651ce008f0
src/slave/state.hpp 7e887058b7fd01913e51a195e6240ce625df2016
src/slave/state.cpp aab8d0b090c7b821fe55aec640d37d1aab9fe7ed
Diff: https://reviews.apache.org/r/13789/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13789: Exposed recovery errors that are encountered in
non-strict recovery mode.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13789/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 4:08 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's and rebased. NNFR.
Bugs: MESOS-663
https://issues.apache.org/jira/browse/MESOS-663
Repository: mesos-git
Description
-------
Number of recovery errors ignored while in non-strict mode are now exposed.
Diffs (updated)
-----
src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316
src/slave/slave.hpp aca7f031fb987d1c522c634680dd2c56623b4753
src/slave/slave.cpp dd599a7cbc7ccef9201f7a294524b24bdaa9d241
src/slave/state.hpp 7e887058b7fd01913e51a195e6240ce625df2016
src/slave/state.cpp b66aaa3dd012249d396a0b3c727d9862f2880179
Diff: https://reviews.apache.org/r/13789/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13789: Exposed recovery errors that are encountered in
non-strict recovery mode.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 24, 2013, 2:50 a.m., Ben Mahler wrote:
> > Did you manually verify this works as you expect?
yes.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13789/#review25494
-----------------------------------------------------------
On Aug. 24, 2013, 12:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13789/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-663
> https://issues.apache.org/jira/browse/MESOS-663
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Number of recovery errors ignored while in non-strict mode are now exposed.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316
> src/slave/slave.hpp aca7f031fb987d1c522c634680dd2c56623b4753
> src/slave/slave.cpp 563a0997b1fec7c827bd6950c449fa651ce008f0
> src/slave/state.hpp 7e887058b7fd01913e51a195e6240ce625df2016
> src/slave/state.cpp aab8d0b090c7b821fe55aec640d37d1aab9fe7ed
>
> Diff: https://reviews.apache.org/r/13789/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13789: Exposed recovery errors that are encountered in
non-strict recovery mode.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13789/#review25494
-----------------------------------------------------------
Ship it!
Did you manually verify this works as you expect?
src/slave/slave.hpp
<https://reviews.apache.org/r/13789/#comment49944>
unsigned int
src/slave/slave.cpp
<https://reviews.apache.org/r/13789/#comment49945>
s/while/during/
Consider:
4 errors encountered during recovery
vs
Errors encountered during recovery: 4
src/slave/state.hpp
<https://reviews.apache.org/r/13789/#comment49946>
unsigned int here and elsewhere
- Ben Mahler
On Aug. 24, 2013, 12:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13789/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-663
> https://issues.apache.org/jira/browse/MESOS-663
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Number of recovery errors ignored while in non-strict mode are now exposed.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 073d0923febf697dec2a9bbfa6e3b243bcab7316
> src/slave/slave.hpp aca7f031fb987d1c522c634680dd2c56623b4753
> src/slave/slave.cpp 563a0997b1fec7c827bd6950c449fa651ce008f0
> src/slave/state.hpp 7e887058b7fd01913e51a195e6240ce625df2016
> src/slave/state.cpp aab8d0b090c7b821fe55aec640d37d1aab9fe7ed
>
> Diff: https://reviews.apache.org/r/13789/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>