[GitHub] [spark] tdas commented on a change in pull request #25023: [SPARK-28223][SS] stream-stream joins should fail unsupported checker in update mode

[GitBox <gi...@apache.org>]

tdas commented on a change in pull request #25023: [SPARK-28223][SS] stream-stream joins should fail unsupported checker in update mode
URL: https://github.com/apache/spark/pull/25023#discussion_r299241557
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
 ##########
 @@ -422,6 +422,14 @@ class UnsupportedOperationsSuite extends SparkFunSuite {
     streamStreamSupported = false,
     expectedMsg = "outer join")
 
+  // Left outer joins: update mode not allowed
+  assertNotSupportedInStreamingPlan(
+    s"left outer join with stream-stream relations and update mode",
+    streamRelation.join(streamRelation, joinType = LeftOuter,
+      condition = Some(attribute === attribute)),
+    OutputMode.Update(),
 
 Review comment:
   shouldnt there be a test for complete mode as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org