You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Kolbasov <ak...@cloudera.com> on 2017/11/28 01:21:33 UTC
HMS dependency on fb303.FacebookService
The hive_metastore.thrift has a dependency on fb303.FacebookService - the
ThriftHiveMetastore extends it. It looks like the only thing that it is
actually using is the shutdown() method.
As an experiment I removed the dependency and the call to shutdown() method
and everything seems to compile just fine (I have not run any actual tests
yet).
Does anyone think that FacebookService provides anything useful or it is
just an lod cruft that should be removed?
- Alex
Re: HMS dependency on fb303.FacebookService
Posted by Alan Gates <al...@gmail.com>.
Works for me.
Alan.
Sent from my iPhone
> On Nov 28, 2017, at 10:55, Alexander Kolbasov <ak...@cloudera.com> wrote:
>
> Thanks for the reply Alan!
>
> The major problem with fb303 is that it is always a pain to deal with it
> when you need to generate thrift code for other purposes. For backwards
> compatibility we may provide some simple implementation ourselves - does
> this sound reasonable?
>
> Alex
>
>> On Tue, Nov 28, 2017 at 9:35 AM, Alan Gates <al...@gmail.com> wrote:
>>
>> Removing this break our backwards compatibility. This interface provides
>> public methods like getName. Hive may not be using them but we have no
>> idea if others are in the wild. Given that including this has little or no
>> cost to us AFAIK, why remove it?
>>
>> Alan.
>>
>> On Mon, Nov 27, 2017 at 5:21 PM, Alexander Kolbasov <ak...@cloudera.com>
>> wrote:
>>
>>> The hive_metastore.thrift has a dependency on fb303.FacebookService -
>> the
>>> ThriftHiveMetastore extends it. It looks like the only thing that it is
>>> actually using is the shutdown() method.
>>>
>>> As an experiment I removed the dependency and the call to shutdown()
>> method
>>> and everything seems to compile just fine (I have not run any actual
>> tests
>>> yet).
>>>
>>> Does anyone think that FacebookService provides anything useful or it is
>>> just an lod cruft that should be removed?
>>>
>>> - Alex
>>>
>>
Re: HMS dependency on fb303.FacebookService
Posted by Alexander Kolbasov <ak...@cloudera.com>.
Thanks for the reply Alan!
The major problem with fb303 is that it is always a pain to deal with it
when you need to generate thrift code for other purposes. For backwards
compatibility we may provide some simple implementation ourselves - does
this sound reasonable?
Alex
On Tue, Nov 28, 2017 at 9:35 AM, Alan Gates <al...@gmail.com> wrote:
> Removing this break our backwards compatibility. This interface provides
> public methods like getName. Hive may not be using them but we have no
> idea if others are in the wild. Given that including this has little or no
> cost to us AFAIK, why remove it?
>
> Alan.
>
> On Mon, Nov 27, 2017 at 5:21 PM, Alexander Kolbasov <ak...@cloudera.com>
> wrote:
>
> > The hive_metastore.thrift has a dependency on fb303.FacebookService -
> the
> > ThriftHiveMetastore extends it. It looks like the only thing that it is
> > actually using is the shutdown() method.
> >
> > As an experiment I removed the dependency and the call to shutdown()
> method
> > and everything seems to compile just fine (I have not run any actual
> tests
> > yet).
> >
> > Does anyone think that FacebookService provides anything useful or it is
> > just an lod cruft that should be removed?
> >
> > - Alex
> >
>
Re: HMS dependency on fb303.FacebookService
Posted by Alan Gates <al...@gmail.com>.
Removing this break our backwards compatibility. This interface provides
public methods like getName. Hive may not be using them but we have no
idea if others are in the wild. Given that including this has little or no
cost to us AFAIK, why remove it?
Alan.
On Mon, Nov 27, 2017 at 5:21 PM, Alexander Kolbasov <ak...@cloudera.com>
wrote:
> The hive_metastore.thrift has a dependency on fb303.FacebookService - the
> ThriftHiveMetastore extends it. It looks like the only thing that it is
> actually using is the shutdown() method.
>
> As an experiment I removed the dependency and the call to shutdown() method
> and everything seems to compile just fine (I have not run any actual tests
> yet).
>
> Does anyone think that FacebookService provides anything useful or it is
> just an lod cruft that should be removed?
>
> - Alex
>