You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/08 03:35:21 UTC

[GitHub] [shardingsphere] dmsolr opened a new pull request #8526: Enhancement plugin class loader

dmsolr opened a new pull request #8526:
URL: https://github.com/apache/shardingsphere/pull/8526


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #8526: Enhancement plugin class loader

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #8526:
URL: https://github.com/apache/shardingsphere/pull/8526#discussion_r538030457



##########
File path: shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/AgentPluginLoader.java
##########
@@ -191,7 +219,7 @@ public PluginAdviceDefinition loadPluginAdviceDefine(final TypeDescription typeD
      * To get or create instance of the advice class. Create new one and caching when it is not exist.
      *
      * @param classNameOfAdvice class name of advice
-     * @param <T> advice type
+     * @param <T>               advice type

Review comment:
       remove this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 merged pull request #8526: Enhancement plugin class loader

Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #8526:
URL: https://github.com/apache/shardingsphere/pull/8526


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org