You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mcgilman (via GitHub)" <gi...@apache.org> on 2026/05/27 13:29:52 UTC
[PR] NIFI-15978: Rendering allowable value descriptions in the Connector w… [nifi]
mcgilman opened a new pull request, #11286:
URL: https://github.com/apache/nifi/pull/11286
…izard.
### NIFI-15978 Rendering allowable value descriptions in the Connector wizard
## Summary
The Connector wizard's property dropdowns currently render only an allowable value's display name, even though the framework's `AllowableValueDTO` already serializes a `description` field (used elsewhere — e.g. processor property dialogs — to give users context about each option). This PR plumbs that description through to the wizard's `searchable-select` so users see the same secondary descriptive text per option that they see in the rest of the UI.
## Changes
- **`libs/shared/src/types/index.ts`** — Added the optional `description?: string` to the nested `AllowableValue.allowableValue` shape so it matches what the backend already returns from `AllowableValueDTO`.
- **`libs/shared/src/components/connector-property-input/connector-property-input.component.ts`** — In `computeSelectOptions`, propagate `av.allowableValue.description` onto the emitted `SearchableSelectOption`. The `searchable-select` component already renders an option's `description` as a secondary line (and already sizes virtual-scroll rows accordingly), so no template or styling changes are needed.
- **`libs/shared/src/components/connector-property-input/connector-property-input.component.spec.ts`** — Extended the `makeAllowable` helper to accept an optional description, adjusted existing assertions to expect `description: undefined` where appropriate, and added focused specs covering description propagation for both the static `property.allowableValues` path and the dynamic `PropertyAllowableValuesState` path.
## Backend alignment
No backend changes are required. Verified that:
- `AllowableValueDTO` already exposes `description` (`getDescription()` / `setDescription()`).
- `DtoFactory.createAllowableValueDto(...)` populates the description for statically declared allowable values.
- `StandardNiFiServiceFacade` populates the description for allowable values produced dynamically via a property's `AllowableValuesProvider`.
So any connector that declares descriptions on its `AllowableValue`s — static or dynamic — will surface them in the wizard with no further wiring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15978: Rendering allowable value descriptions in the Connector w… [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan merged PR #11286:
URL: https://github.com/apache/nifi/pull/11286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15978: Rendering allowable value descriptions in the Connector w… [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on PR #11286:
URL: https://github.com/apache/nifi/pull/11286#issuecomment-4555935800
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org