You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/26 07:07:07 UTC
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32333: [SPARK-33985][SQL][TESTS] Add query test of combine usage of TRANSFORM and CLUSTER BY/ORDER BY
AngersZhuuuu commented on a change in pull request #32333:
URL: https://github.com/apache/spark/pull/32333#discussion_r620011217
##########
File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql
##########
@@ -342,3 +354,41 @@ SELECT TRANSFORM(b, MAX(a) AS max_a, CAST(sum(c) AS STRING))
FROM script_trans
WHERE a <= 2
GROUP BY b;
+
+-- SPARK-33985 TRANSFORM with CLUSTER BY/ORDER BY/SORT BY
Review comment:
> nit: `SPARK-33985 ` -> `SPARK-33985: `
Done
##########
File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql
##########
@@ -342,3 +354,41 @@ SELECT TRANSFORM(b, MAX(a) AS max_a, CAST(sum(c) AS STRING))
FROM script_trans
WHERE a <= 2
GROUP BY b;
+
+-- SPARK-33985: TRANSFORM with CLUSTER BY/ORDER BY/SORT BY
+FROM (
Review comment:
> can we use the standard TRANSFORM syntax? Or we write the tests for hive compatibility?
Yea, for compatibility, since we have less test about transform before. Since I am always checking transform use case between hive and spark.
##########
File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql
##########
@@ -342,3 +354,41 @@ SELECT TRANSFORM(b, MAX(a) AS max_a, CAST(sum(c) AS STRING))
FROM script_trans
WHERE a <= 2
GROUP BY b;
+
+-- SPARK-33985: TRANSFORM with CLUSTER BY/ORDER BY/SORT BY
+FROM (
Review comment:
> can we use the standard TRANSFORM syntax? Or we write the tests for hive compatibility?
Yea, for compatibility, since we have less test about transform before. Since I am always checking transform use case between hive and spark. Since this is a important use case of hive's script transform, so add tests to confirm the compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org