You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/11/16 22:34:12 UTC

Review Request 40368: Storm Upgrade Causes NPE Due To null Property Value Replacement

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40368/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.


Bugs: AMBARI-13915
    https://issues.apache.org/jira/browse/AMBARI-13915


Repository: ambari


Description
-------

In an upgrade (either rolling or express), the {{storm-site}} property replacement for 

{code}
<replace key="nimbus.authorizer" find="com.xasecure.authorization.storm.authorizer.XaSecureStormAuthorizer" replace-with="org.apache.ranger.authorization.storm.authorizer.RangerStormAuthorizer" />
{code}

causes

{code}
10 Nov 2015 05:06:34,332  WARN [Server Action Executor Worker 264] ServerActionExecutor:479 - Task #264 failed to complete execution due to thrown exception: java.lang.NullPointerException:null
java.lang.NullPointerException
        at org.apache.ambari.server.serveraction.upgrades.ConfigureAction.execute(ConfigureAction.java:410)
        at org.apache.ambari.server.serveraction.ServerActionExecutor$Worker.execute(ServerActionExecutor.java:537)
        at org.apache.ambari.server.serveraction.ServerActionExecutor$Worker.run(ServerActionExecutor.java:474)
        at java.lang.Thread.run(Thread.java:745)
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java ef21a2a 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java d1d783c 

Diff: https://reviews.apache.org/r/40368/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Re: Review Request 40368: Storm Upgrade Causes NPE Due To null Property Value Replacement

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40368/#review106763
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Nov. 16, 2015, 9:34 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40368/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 9:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-13915
>     https://issues.apache.org/jira/browse/AMBARI-13915
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In an upgrade (either rolling or express), the {{storm-site}} property replacement for 
> 
> {code}
> <replace key="nimbus.authorizer" find="com.xasecure.authorization.storm.authorizer.XaSecureStormAuthorizer" replace-with="org.apache.ranger.authorization.storm.authorizer.RangerStormAuthorizer" />
> {code}
> 
> causes
> 
> {code}
> 10 Nov 2015 05:06:34,332  WARN [Server Action Executor Worker 264] ServerActionExecutor:479 - Task #264 failed to complete execution due to thrown exception: java.lang.NullPointerException:null
> java.lang.NullPointerException
>         at org.apache.ambari.server.serveraction.upgrades.ConfigureAction.execute(ConfigureAction.java:410)
>         at org.apache.ambari.server.serveraction.ServerActionExecutor$Worker.execute(ServerActionExecutor.java:537)
>         at org.apache.ambari.server.serveraction.ServerActionExecutor$Worker.run(ServerActionExecutor.java:474)
>         at java.lang.Thread.run(Thread.java:745)
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java ef21a2a 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java d1d783c 
> 
> Diff: https://reviews.apache.org/r/40368/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 40368: Storm Upgrade Causes NPE Due To null Property Value Replacement

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40368/#review106740
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Nov. 16, 2015, 9:34 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40368/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 9:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-13915
>     https://issues.apache.org/jira/browse/AMBARI-13915
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In an upgrade (either rolling or express), the {{storm-site}} property replacement for 
> 
> {code}
> <replace key="nimbus.authorizer" find="com.xasecure.authorization.storm.authorizer.XaSecureStormAuthorizer" replace-with="org.apache.ranger.authorization.storm.authorizer.RangerStormAuthorizer" />
> {code}
> 
> causes
> 
> {code}
> 10 Nov 2015 05:06:34,332  WARN [Server Action Executor Worker 264] ServerActionExecutor:479 - Task #264 failed to complete execution due to thrown exception: java.lang.NullPointerException:null
> java.lang.NullPointerException
>         at org.apache.ambari.server.serveraction.upgrades.ConfigureAction.execute(ConfigureAction.java:410)
>         at org.apache.ambari.server.serveraction.ServerActionExecutor$Worker.execute(ServerActionExecutor.java:537)
>         at org.apache.ambari.server.serveraction.ServerActionExecutor$Worker.run(ServerActionExecutor.java:474)
>         at java.lang.Thread.run(Thread.java:745)
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java ef21a2a 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java d1d783c 
> 
> Diff: https://reviews.apache.org/r/40368/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>