[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5301: HDFS-16892. Fix method name of RPC.Builder#setnumReaders

["haiyang1987 (via GitHub)" <gi...@apache.org>]

haiyang1987 commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1095503796


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) {
      * @return Default: -1.
      * @param numReaders input numReaders.
      */
-    public Builder setnumReaders(int numReaders) {
+    public Builder setNumReaders(int numReaders) {

Review Comment:
   Hi @tomscut @steveloughran @ayushtkn thanks help review it.
   
   sorry for the late reply.
   
   Considering that it is a public method in a public class and avoid compilation failures in downstream use, you can create a new method as @steveloughran  said, and keep the old method as deprecated, which may be better.
   
   I will update PR later.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org