You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:27:35 UTC
Review Request 70914: Defined `mapped_type` for `ResourceQuantities`
and `ResourceLimits`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70914/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
This let the two pass the `HasMappedType` and benefit from
templated functions such as `json`.
Diffs
-----
include/mesos/resource_quantities.hpp c861df8a8a167b19ea8374c22cdd2a8fe567a6a6
Diff: https://reviews.apache.org/r/70914/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70914: Defined `mapped_type` for
`ResourceQuantities` and `ResourceLimits`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On June 21, 2019, 1:35 p.m., Benjamin Mahler wrote:
> > This makes the json serialization pretty implicit, why not just add explicit json serialization functions for these types? I'm not that familiar with the other implications of adding mapped_type, are you?
This would avoid a copy/construction of a dictionary type.
But yeah, I realize this might be too implicit. Discarding this patch, added dedicated writers in subsequent patches.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70914/#review216068
-----------------------------------------------------------
On June 20, 2019, 7:27 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70914/
> -----------------------------------------------------------
>
> (Updated June 20, 2019, 7:27 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This let the two pass the `HasMappedType` and benefit from
> templated functions such as `json`.
>
>
> Diffs
> -----
>
> include/mesos/resource_quantities.hpp c861df8a8a167b19ea8374c22cdd2a8fe567a6a6
>
>
> Diff: https://reviews.apache.org/r/70914/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70914: Defined `mapped_type` for
`ResourceQuantities` and `ResourceLimits`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70914/#review216068
-----------------------------------------------------------
This makes the json serialization pretty implicit, why not just add explicit json serialization functions for these types? I'm not that familiar with the other implications of adding mapped_type, are you?
- Benjamin Mahler
On June 21, 2019, 2:27 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70914/
> -----------------------------------------------------------
>
> (Updated June 21, 2019, 2:27 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This let the two pass the `HasMappedType` and benefit from
> templated functions such as `json`.
>
>
> Diffs
> -----
>
> include/mesos/resource_quantities.hpp c861df8a8a167b19ea8374c22cdd2a8fe567a6a6
>
>
> Diff: https://reviews.apache.org/r/70914/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>