You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/04/18 19:20:26 UTC
[kudu-CR] log-test: Add additional assert
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6674
to review the following change.
Change subject: log-test: Add additional assert
......................................................................
log-test: Add additional assert
This just adds an additional check which is nice to have in this test.
This was added in a backport to the 1.2.x branch and so is also being
added here.
Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
---
M src/kudu/consensus/log-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6674/1
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] log-test: Add additional assert
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: log-test: Add additional assert
......................................................................
log-test: Add additional assert
This just adds an additional check which is nice to have in this test.
This was added in a backport to the 1.2.x branch and so is also being
added here.
Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Reviewed-on: http://gerrit.cloudera.org:8080/6674
Tested-by: Mike Percy <mp...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/log-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Mike Percy: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] log-test: Add additional assert
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: log-test: Add additional assert
......................................................................
Patch Set 2: Verified+1
Overriding existing test failure due to KUDU-1736
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] log-test: Add additional assert
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6674
to look at the new patch set (#2).
Change subject: log-test: Add additional assert
......................................................................
log-test: Add additional assert
This just adds an additional check which is nice to have in this test.
This was added in a backport to the 1.2.x branch and so is also being
added here.
Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
---
M src/kudu/consensus/log-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6674/2
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] log-test: Add additional assert
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: log-test: Add additional assert
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] log-test: Add additional assert
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: log-test: Add additional assert
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:
PS1, Line 1020: INT32_MAX
> nit: why not to use std::numeric_limits<int32_t>::max() here as well (as it
Done
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] log-test: Add additional assert
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: log-test: Add additional assert
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:
PS1, Line 1020: INT32_MAX
nit: why not to use std::numeric_limits<int32_t>::max() here as well (as it's already for assigning first_log_index it's initial value)?
--
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes