You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "RamonZhou (via GitHub)" <gi...@apache.org> on 2026/09/03 18:10:23 UTC
[PR] [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI [spark]
RamonZhou opened a new pull request, #58502:
URL: https://github.com/apache/spark/pull/58502
### What changes were proposed in this pull request?
Pass `container-runtime: docker` to both `medyagh/setup-minikube` steps in
`.github/workflows/build_and_test.yml` -- the `k8s-integration-tests` job and the
`oidc-e2e` job -- so the Minikube node's container runtime is chosen explicitly instead of
inherited from the Minikube default.
### Why are the changes needed?
The K8s integration test job currently fails for every PR, during image construction.
[Minikube 1.39.0](https://github.com/kubernetes/minikube/releases/tag/v1.39.0) changed the
default container runtime from Docker to containerd
([kubernetes/minikube#23562](https://github.com/kubernetes/minikube/pull/23562)). Both jobs
pin `setup-minikube` by SHA but leave `minikube-version` at the action's default of
`latest`, so CI picked up 1.39.0 as soon as it was released and the node now comes up on
containerd:
```
* minikube v1.39.0 on Ubuntu 24.04
* Automatically selected the docker driver.
* Preparing Kubernetes v1.37.0 on containerd 2.3.4 ...
Container Runtime Version: containerd://2.3.4
```
Both jobs then build images through `eval $(minikube docker-env)`, which now points at
containerd's Docker shim rather than a real Docker daemon:
```
! Using the docker-env command with the containerd runtime is a highly experimental
feature, please provide feedback or contribute to make it better
```
That shim does not implement enough of the Docker API for buildx. Because the pointed-at
endpoint is not a usable Docker daemon, buildx falls back to the `docker-container` driver,
and bootstrapping BuildKit inside it fails:
```
#0 building with "default" instance using docker-container driver
#1 [internal] booting buildkit
#1 pulling image moby/buildkit:buildx-stable-1 2.7s done
#1 ERROR: failed to inspect pulled image moby/buildkit:buildx-stable-1: Error response from daemon: 404 page not found
ERROR: failed to build: failed to inspect pulled image moby/buildkit:buildx-stable-1: Error response from daemon: 404 page not found
[error] (kubernetes-integration-tests / dockerImgs) java.lang.IllegalStateException: Process ... exited with code 1
```
Minikube 1.38.1 still defaults to the Docker runtime and passes; 1.39.0 fails consistently.
`container-runtime: docker` is the fix rather than pinning `minikube-version`, because it
addresses the cause and does not freeze CI on an aging Minikube. The Docker runtime remains
fully supported in 1.39.0 -- that release ships cri-dockerd v0.4.3 and includes a
cri-dockerd fix specifically for Kubernetes v1.36+
([kubernetes/minikube#22921](https://github.com/kubernetes/minikube/pull/22921)) -- so
`docker` stays a valid choice for the Kubernetes versions these two jobs use (1.37.0 and
1.36.0). Runners are x86_64, which cri-dockerd supports.
Fixing only `k8s-integration-tests` would leave `oidc-e2e` broken, since it builds its
image the same way; both steps are updated.
### Does this PR introduce _any_ user-facing change?
No. This is a CI-only change.
### How was this patch tested?
By CI in this PR. This change touches only `.github`, which `dev/is-changed.py` maps to the
`root` module, so both `k8s-integration-tests` and `oidc-e2e` run here and exercise the
image build path that was failing.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58502:
URL: https://github.com/apache/spark/pull/58502#issuecomment-5530720301
To @RamonZhou , I added your JIRA ID (`Kaicheng Zhou`) to the Apache Spark contributor group and assigned SPARK-59212 to you.
Congratulation for your first commit and welcome to the Apache Spark community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58502:
URL: https://github.com/apache/spark/pull/58502#issuecomment-5530665813
I verified that the K8s integration test is currently running correctly. I'm going to merge this to unblock the other PRs.
```
[info] KubernetesSuite:
[info] - SPARK-42190: Run SparkPi with local[*] (17 seconds, 226 milliseconds)
[info] - Run SparkPi with no resources (17 seconds, 98 milliseconds)
[info] - SPARK-53944: Run SparkPi without driver service (17 seconds, 846 milliseconds)
[info] - Run SparkPi with no resources & statefulset allocation (18 seconds, 964 milliseconds)
[info] - Run SparkPi with a very long application name. (18 seconds, 159 milliseconds)
[info] - Use SparkLauncher.NO_RESOURCE (17 seconds, 404 milliseconds)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58502:
URL: https://github.com/apache/spark/pull/58502#issuecomment-5530696220
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/680855bea7393b383a77f1711fe640cb7fad604b
- merged into branch-4.x https://github.com/apache/spark/commit/645175cc6dd09e7180fb4adec77c8b3f13dc31c9
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58502: [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI
URL: https://github.com/apache/spark/pull/58502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59212][K8S][INFRA] Pin the Minikube container runtime to `docker` in K8s CI [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58502:
URL: https://github.com/apache/spark/pull/58502#issuecomment-5530592797
Thank you for making a PR, @RamonZhou .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org