You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/21 09:02:44 UTC
[GitHub] [spark] xuanyuanking opened a new pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
xuanyuanking opened a new pull request #32270:
URL: https://github.com/apache/spark/pull/32270
### What changes were proposed in this pull request?
Declare the markdown package as a dependency of the SparkR package
### Why are the changes needed?
If we didn't install pandoc locally, running make-distribution.sh will fail with the following message:
```
— re-building ‘sparkr-vignettes.Rmd’ using rmarkdown
Warning in engine$weave(file, quiet = quiet, encoding = enc) :
Pandoc (>= 1.12.3) not available. Falling back to R Markdown v1.
Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics:
The 'markdown' package should be declared as a dependency of the 'SparkR' package (e.g., in the 'Suggests' field of DESCRIPTION), because the latter contains vignette(s) built with the 'markdown' package. Please see https://github.com/yihui/knitr/issues/1864 for more information.
— failed re-building ‘sparkr-vignettes.Rmd’
```
### Does this PR introduce _any_ user-facing change?
Yes. Workaround for R packaging.
### How was this patch tested?
Manually test. After the fix, the command `sh dev/make-distribution.sh -Psparkr -Phadoop-2.7 -Phive -Phive-thriftserver -Pyarn` in the environment without pandoc will pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32270:
URL: https://github.com/apache/spark/pull/32270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-846651695
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-846616392
Thank you, @xuanyuanking and @HyukjinKwon .
During testing `branch-3.1`, I saw the `Error` message.
I'll backport this to branch-3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823946330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823957288
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823906789
**[Test build #137722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137722/testReport)** for PR 32270 at commit [`ad9a572`](https://github.com/apache/spark/commit/ad9a572438e8a95e0dc13ecb7b2cdd5740d959a1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823942132
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137722/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823942132
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137722/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823906789
**[Test build #137722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137722/testReport)** for PR 32270 at commit [`ad9a572`](https://github.com/apache/spark/commit/ad9a572438e8a95e0dc13ecb7b2cdd5740d959a1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823946382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42249/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823995977
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32270: [SPARK-35171][R] Declare the markdown package as a dependency of the SparkR package
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32270:
URL: https://github.com/apache/spark/pull/32270#issuecomment-823946382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42249/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org