You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/23 12:30:28 UTC
[GitHub] [lucene] rmuir opened a new pull request, #832: LUCENE-10523: remove @Slow annotation
rmuir opened a new pull request, #832:
URL: https://github.com/apache/lucene/pull/832
This annotation is such an antipattern, it is so harmful to our codebase.
* gives the impression that "slow tests are ok"
* it is like "support for slow tests"
* allows certain privileged ppl to skip slow tests (those that know the gradle magic)
* probably same people are the ones writing slow tests, not having to live with consequences
* causes differences across runs of different devs for no good reason
we don't need this annotation. we can work together to keep the tests fast. if tests are slow we can all share the pain until we fix the test to be fast.
this thing is a real antipattern, i think the idea came from solr, but well, look at their tests. let's not be like them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #832: LUCENE-10523: remove @Slow annotation
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #832:
URL: https://github.com/apache/lucene/pull/832#issuecomment-1108486770
I'm fine with this. Reasons for Slow (and other test groups) are various. I use Slow in projects where certain tests are indeed slow by nature - have to unpack the distribution/ fork processes or start networking layers. These are typically integration tests. They run on the CI but they're not mandatory for local developer runs. I don't think this is needed in Lucene either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #832: LUCENE-10532: remove @Slow annotation
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #832:
URL: https://github.com/apache/lucene/pull/832#issuecomment-1121826968
Thanks @cpoerschke for correcting my dyslexia :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #832: LUCENE-10532: remove @Slow annotation
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #832:
URL: https://github.com/apache/lucene/pull/832#issuecomment-1121832123
> I'm fine with this. Reasons for Slow (and other test groups) are various. I use Slow in projects where certain tests are indeed slow by nature - have to unpack the distribution/ fork processes or start networking layers. These are typically integration tests. They run on the CI but they're not mandatory for local developer runs. I don't think this is needed in Lucene either.
I like the idea of the test groups actually, it came up on another PR: https://github.com/apache/lucene/pull/633 . I just think lucene would do better with different test groups to better test what we need (e.g. something like suggested `@Concurrent`. The `@Slow` doesn't help us IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #832: LUCENE-10532: remove @Slow annotation
Posted by GitBox <gi...@apache.org>.
rmuir merged PR #832:
URL: https://github.com/apache/lucene/pull/832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org