You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/25 05:53:43 UTC

[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #2946: Add retrying kyuubi sync thrift client for engine connection

turboFei opened a new pull request, #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906935703


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -160,13 +163,32 @@ abstract class TFrontendService(name: String)
     val ipAddress = getIpAddress
     val configuration =
       Option(req.getConfiguration).map(_.asScala.toMap).getOrElse(Map.empty[String, String])
-    val sessionHandle = be.openSession(
-      protocol,
-      userName,
-      req.getPassword,
-      ipAddress,
-      configuration)
-    sessionHandle
+
+    val sessionHandleGuid =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_GUID)
+    val sessionHandleSecret =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_SECRET)

Review Comment:
   the original session means original context, If we create a new session, the context is loss



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906931179


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1540,6 +1525,27 @@ object KyuubiConf {
       .stringConf
       .createOptional
 
+  val SESSION_RESERVE_ON_BROKEN_ENABLED: ConfigEntry[Boolean] =
+    buildConf("kyuubi.session.reserve.on.broken.enabled")
+      .internal
+      .doc("Whether to reserve the session on the transport protocol broken. Now we support" +
+        " RetryingKyuubiSyncThriftClient, it will close the recreate the protocol for thrift" +
+        " request retry, and we need reserve the session in engine side for that.")
+      .version("1.6.0")
+      .booleanConf
+      .createWithDefault(false)
+
+  val SESSION_RESERVE_ON_BROKEN_TIMEOUT: ConfigEntry[Long] =

Review Comment:
   the session will be closed on disconnected with these..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906929891


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -160,13 +163,32 @@ abstract class TFrontendService(name: String)
     val ipAddress = getIpAddress
     val configuration =
       Option(req.getConfiguration).map(_.asScala.toMap).getOrElse(Map.empty[String, String])
-    val sessionHandle = be.openSession(
-      protocol,
-      userName,
-      req.getPassword,
-      ipAddress,
-      configuration)
-    sessionHandle
+
+    val sessionHandleGuid =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_GUID)
+    val sessionHandleSecret =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_SECRET)

Review Comment:
   recreate the protocol and connect to the original session



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei closed pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #2946: Add retrying kyuubi thrift client for internal engine connection
URL: https://github.com/apache/incubator-kyuubi/pull/2946


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2946: Add retrying kyuubi sync thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#issuecomment-1166222032

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2946](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f4a36) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/37c0d4258c5c05cd31dcdaa4cd44fa0e97f607f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37c0d42) will **decrease** coverage by `0.09%`.
   > The diff coverage is `85.08%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2946      +/-   ##
   ============================================
   - Coverage     62.89%   62.79%   -0.10%     
     Complexity        6        6              
   ============================================
     Files           418      420       +2     
     Lines         20283    20219      -64     
     Branches       2594     2585       -9     
   ============================================
   - Hits          12757    12697      -60     
   - Misses         6285     6295      +10     
   + Partials       1241     1227      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/kyuubi/config/KyuubiReservedKeys.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpUmVzZXJ2ZWRLZXlzLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `88.41% <55.55%> (-2.16%)` | :arrow_down: |
   | [...kyuubi/client/RetryingKyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvUmV0cnlpbmdLeXV1YmlTeW5jVGhyaWZ0Q2xpZW50LnNjYWxh) | `85.71% <85.71%> (ø)` | |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `87.74% <91.89%> (-0.60%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.07% <100.00%> (-0.13%)` | :arrow_down: |
   | [...apache/kyuubi/client/IKyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvSUt5dXViaVN5bmNUaHJpZnRDbGllbnQuc2NhbGE=) | `100.00% <100.00%> (ø)` | |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `75.00% <100.00%> (+1.50%)` | :arrow_up: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `66.66% <0.00%> (-2.67%)` | :arrow_down: |
   | [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `77.94% <0.00%> (-1.48%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37c0d42...b4f4a36](https://codecov.io/gh/apache/incubator-kyuubi/pull/2946?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#issuecomment-1168678673

   seems not needed, close it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906924216


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1540,6 +1525,27 @@ object KyuubiConf {
       .stringConf
       .createOptional
 
+  val SESSION_RESERVE_ON_BROKEN_ENABLED: ConfigEntry[Boolean] =
+    buildConf("kyuubi.session.reserve.on.broken.enabled")
+      .internal
+      .doc("Whether to reserve the session on the transport protocol broken. Now we support" +
+        " RetryingKyuubiSyncThriftClient, it will close the recreate the protocol for thrift" +
+        " request retry, and we need reserve the session in engine side for that.")
+      .version("1.6.0")
+      .booleanConf
+      .createWithDefault(false)
+
+  val SESSION_RESERVE_ON_BROKEN_TIMEOUT: ConfigEntry[Long] =

Review Comment:
   `kyuubi.session.reserve.*` are unnecessary as a retry logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906929891


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -160,13 +163,32 @@ abstract class TFrontendService(name: String)
     val ipAddress = getIpAddress
     val configuration =
       Option(req.getConfiguration).map(_.asScala.toMap).getOrElse(Map.empty[String, String])
-    val sessionHandle = be.openSession(
-      protocol,
-      userName,
-      req.getPassword,
-      ipAddress,
-      configuration)
-    sessionHandle
+
+    val sessionHandleGuid =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_GUID)
+    val sessionHandleSecret =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_SECRET)

Review Comment:
   recreate the protocol and connect to the old session



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906924672


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -160,13 +163,32 @@ abstract class TFrontendService(name: String)
     val ipAddress = getIpAddress
     val configuration =
       Option(req.getConfiguration).map(_.asScala.toMap).getOrElse(Map.empty[String, String])
-    val sessionHandle = be.openSession(
-      protocol,
-      userName,
-      req.getPassword,
-      ipAddress,
-      configuration)
-    sessionHandle
+
+    val sessionHandleGuid =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_GUID)
+    val sessionHandleSecret =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_SECRET)

Review Comment:
   in which case, we need these?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906932980


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -160,13 +163,32 @@ abstract class TFrontendService(name: String)
     val ipAddress = getIpAddress
     val configuration =
       Option(req.getConfiguration).map(_.asScala.toMap).getOrElse(Map.empty[String, String])
-    val sessionHandle = be.openSession(
-      protocol,
-      userName,
-      req.getPassword,
-      ipAddress,
-      configuration)
-    sessionHandle
+
+    val sessionHandleGuid =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_GUID)
+    val sessionHandleSecret =
+      configuration.get(KyuubiReservedKeys.KYUUBI_SESSION_HANDLE_SECRET)

Review Comment:
   in which case we need the original session?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906930657


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1540,6 +1525,27 @@ object KyuubiConf {
       .stringConf
       .createOptional
 
+  val SESSION_RESERVE_ON_BROKEN_ENABLED: ConfigEntry[Boolean] =
+    buildConf("kyuubi.session.reserve.on.broken.enabled")
+      .internal
+      .doc("Whether to reserve the session on the transport protocol broken. Now we support" +
+        " RetryingKyuubiSyncThriftClient, it will close the recreate the protocol for thrift" +
+        " request retry, and we need reserve the session in engine side for that.")
+      .version("1.6.0")
+      .booleanConf
+      .createWithDefault(false)
+
+  val SESSION_RESERVE_ON_BROKEN_TIMEOUT: ConfigEntry[Long] =

Review Comment:
   it is used to tell the engine front end service that do not close the session on protocol broken.
   
   Otherwise, the session will be closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2946: Add retrying kyuubi thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#discussion_r906936090


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1540,6 +1525,27 @@ object KyuubiConf {
       .stringConf
       .createOptional
 
+  val SESSION_RESERVE_ON_BROKEN_ENABLED: ConfigEntry[Boolean] =
+    buildConf("kyuubi.session.reserve.on.broken.enabled")
+      .internal
+      .doc("Whether to reserve the session on the transport protocol broken. Now we support" +
+        " RetryingKyuubiSyncThriftClient, it will close the recreate the protocol for thrift" +
+        " request retry, and we need reserve the session in engine side for that.")
+      .version("1.6.0")
+      .booleanConf
+      .createWithDefault(false)
+
+  val SESSION_RESERVE_ON_BROKEN_TIMEOUT: ConfigEntry[Long] =

Review Comment:
   yeah, so we need this config to reserve the old context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #2946: Add retrying kyuubi sync thrift client for internal engine connection

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2946:
URL: https://github.com/apache/incubator-kyuubi/pull/2946#issuecomment-1166302675

   test passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org