You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/29 13:11:01 UTC

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #12826: proofread SQLServer TCL statements

ThanoshanMV opened a new pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826


   For #6478
   
   Hi @jingshanglu, I've added SQL definitions for SQLServer [TCL](https://docs.microsoft.com/en-us/sql/t-sql/language-elements/transactions-transact-sql?view=sql-server-ver15) statements. Please check it.
   
   Changes proposed in this pull request:
   - Proofread SQLServer TCL statements.
   - Add corresponding test cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826#issuecomment-930313715


   > > Which case do we need to follow for `sql-case-id`? Currently, `sql-case-id`s are specified in both camel case and snake case.
   > 
   > Thank you for remind. It is better to use `snake-case`. Please submit a new pull request to unify the `sql-case-id` if you are interested. Thanks again.
   
   Thank you. I'll try to unify all `sql-case-id` in `snake-case`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826#issuecomment-930166467


   Which case do we need to follow for `sql-case-id`? Currently, `sql-case-id`s are specified in both camel case and snake case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826#issuecomment-930306911






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826#issuecomment-930306911


   > Which case do we need to follow for `sql-case-id`? Currently, `sql-case-id`s are specified in both camel case and snake case.
   
   Thank you for remind. 
   It is better to use `snake-case`. Please submit a new pull request to unify the `sql-case-id` if you are interested.
   Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826#issuecomment-930166467






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #12826: proofread SQLServer TCL statements

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12826:
URL: https://github.com/apache/shardingsphere/pull/12826#issuecomment-930311115


   I just create the issue #12830 for it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org