You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2011/04/03 01:19:40 UTC
[Bug 6566] New: X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and inaccurate
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Summary: X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and
inaccurate
Product: Spamassassin
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Tools
AssignedTo: dev@spamassassin.apache.org
ReportedBy: david-sarah@jacaranda.org
The default wording of X-Ham-Report, when configured to be included, says that
'Spam detection software, running on the system "_HOSTNAME_", has
report identified this incoming email as possible spam.' This is wrong (for
X-Ham-Report); it should say that the software has identified the email as
probably not spam.
This wording may be shown to mail recipients depending on their MUA settings
(e.g. see
http://forums.cpanel.net/f43/case-45360-ham-being-reported-spam-started-recently-175291-p2.html),
or if they see the full headers in a bounce report. Just being in a header that
isn't normally seen doesn't excuse this inaccuracy.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.4.0 |3.3.2
--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2011-05-05 01:14:51 UTC ---
trunk:
Bug 6566: X-Ham-Report default wording ("has identified this incoming
email as possible spam") is confusing and inaccurate - allow _YESNO_
tag to take arguments, replacing the default "Yes" and "No" with
user-supplied strings'
Sending lib/Mail/SpamAssassin/Conf.pm
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Committed revision 1099646.
Only the code modification from the attached patch has been applied
to trunk, not the change to a reporting template - so there is no
user-perceived change, retaining compatibility.
As the code change is small and does not change existing behaviour by
itself (but enables users to better customize their report if they wish),
consider applying the code change to 3.3.2, and leave modifying the
report template for 3.4.0. Opinions?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|X-Ham-Report default |[review] X-Ham-Report
|wording ("has identified |default wording ("has
|this incoming email as |identified this incoming
|possible spam") is |email as possible spam") is
|confusing and inaccurate |confusing and inaccurate
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #9 from Mark Martinec <Ma...@ijs.si> 2011-05-09 00:39:15 UTC ---
3.3:
Bug 6566: X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and inaccurate
Sending lib/Mail/SpamAssassin/Conf.pm
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending rules/10_default_prefs.cf
Committed revision 1100851.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |macsrwe@macsrwe.com
--- Comment #10 from Kevin A. McGrail <km...@pccc.com> 2012-04-22 13:24:54 UTC ---
*** Bug 6791 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |1 vote needed to commit and
| |change template in 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2011-05-06 00:13:30 UTC ---
Created attachment 4876
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4876
The conditionalized 'report' template, based on 'feature_yesno_takes_args'
trunk:
Bug 6566: X-Ham-Report default wording ("has identified this incoming email
as possible spam") is confusing and inaccurate - conditionalized report
template
Sending lib/Mail/SpamAssassin/Conf.pm
Sending rules/10_default_prefs.cf
Committed revision 1100004.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2011-05-05 01:01:37 UTC ---
Created attachment 4871
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4871
Allow _YESNO_ to take arguments, replacing the"Yes"/"No" defaults
The attached patch extends macros _YESNO_ and _YESNOCAPS_ to take
optional arguments, replacing the default substitutions "Yes" and "No"
with user-supplied strings if specified. Parsing of arguments is
simple-minded, a comma may not appear within the first argument.
Updated docs now say:
=head1 TEMPLATE TAGS
[...]
_YESNO_ "Yes" for spam, "No" for nonspam (=ham)
_YESNO(spam_str,ham_str)_ returns the first argument ("Yes" if missing)
for spam, and the second argument ("No" if missing) for ham
_YESNOCAPS_ "YES" for spam, "NO" for nonspam (=ham)
_YESNOCAPS(spam_str,ham_str)_ same as _YESNO(...)_, but uppercased
The attached patch also modifies the default report template
to take advantage of the above.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hege@hege.li
Status Whiteboard|1 vote needed to commit and |ready to commit and change
|change template in 3.3.2 |template in 3.3.2
--- Comment #8 from Henrik Krohns <he...@hege.li> 2011-05-08 18:51:36 UTC ---
(In reply to comment #7)
> Created attachment 4876 [details]
> The conditionalized 'report' template, based on 'feature_yesno_takes_args'
>
> trunk:
> Bug 6566: X-Ham-Report default wording ("has identified this incoming email
> as possible spam") is confusing and inaccurate - conditionalized report
> template
> Sending lib/Mail/SpamAssassin/Conf.pm
> Sending rules/10_default_prefs.cf
> Committed revision 1100004.
+1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
--- Comment #6 from Mark Martinec <Ma...@ijs.si> 2011-05-05 17:07:19 UTC ---
> > Only the code modification from the attached patch has been applied
> > to trunk, not the change to a reporting template - so there is no
> > user-perceived change, retaining compatibility.
>
> It seems strange to me to consider changing the default wording to be a
> compatibility problem. The wording is wrong.
It's fine by me to commit the change of a report template to 3.3.2,
I just didn't want to do it straight away without approval.
One thing to consider: if a change to 'report' in 10_default_prefs.cf
gets propagated through sa-update to older versions, the report will
not be expanded correctly. I guess this can be handled by 'if version'
and both variants provided.
Btw, the changed report text as suggested by the attached patch yields
either the (for ham):
Spam detection software, running on the system "xxx.xxx.xxx",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
or for spam:
Spam detection software, running on the system "xxx.xxx.xxx",
has identified this incoming email as possible spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and inaccurate
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
David-Sarah Hopwood <da...@jacaranda.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david-sarah@jacaranda.org
--- Comment #1 from David-Sarah Hopwood <da...@jacaranda.org> 2011-04-02 19:23:38 EDT ---
BTW, essentially the same issue was reported back in 2003 as bug 1465, but the
justification for not fixing it then ("we can't fix it without causing trouble
for translators, site customisations, etc.") was really weak.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #4 from Kevin A. McGrail <km...@pccc.com> 2011-05-05 12:00:53 UTC ---
(In reply to comment #3)
> trunk:
> Bug 6566: X-Ham-Report default wording ("has identified this incoming
> email as possible spam") is confusing and inaccurate - allow _YESNO_
> tag to take arguments, replacing the default "Yes" and "No" with
> user-supplied strings'
> Sending lib/Mail/SpamAssassin/Conf.pm
> Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
> Committed revision 1099646.
>
> Only the code modification from the attached patch has been applied
> to trunk, not the change to a reporting template - so there is no
> user-perceived change, retaining compatibility.
>
> As the code change is small and does not change existing behaviour by
> itself (but enables users to better customize their report if they wish),
> consider applying the code change to 3.3.2, and leave modifying the
> report template for 3.4.0. Opinions?
I agree with comment #1. We are overcomplicating this for translation purposes
a bit.
The HAM report should be correct in at least 1 language as part of 3.3.2, IMO.
The weird part is I've never configured HAM reports.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] [review] X-Ham-Report default wording ("has identified
this incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
--- Comment #5 from David-Sarah Hopwood <da...@jacaranda.org> 2011-05-05 16:54:33 UTC ---
(In reply to comment #3)
> Only the code modification from the attached patch has been applied
> to trunk, not the change to a reporting template - so there is no
> user-perceived change, retaining compatibility.
It seems strange to me to consider changing the default wording to be a
compatibility problem. The wording is wrong.
[I filed this report because I saw a bounce message with this incorrect wording
from SpamAssassin, making me think that the message was bounced for being
classified as spam, when actually it was bounced for a different reason (a full
mailbox). Not changing the default would fail to help in reducing the number of
mail recipients who see such confusing messages. That would be dependent on
their correspondants' mail provider changing the SpamAssassin defaults, but
there's no reason why that provider would know of the problem.]
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6566] X-Ham-Report default wording ("has identified this
incoming email as possible spam") is confusing and inaccurate
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6566
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.4.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.