You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/06/02 08:30:37 UTC
Review Request 34926: Added help for state.json
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34926/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-2277
https://issues.apache.org/jira/browse/MESOS-2277
Repository: mesos
Description
-------
Added help for roles.json, state-summary and edited help for state.json
Fixed issues
Diffs
-----
src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0
src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564
src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d
Diff: https://reviews.apache.org/r/34926/diff/
Testing
-------
Make check
Thanks,
Aditi Dixit
Re: Review Request 34926: Added help for state.json
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34926/#review86243
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 2, 2015, 6:34 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34926/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 6:34 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2277
> https://issues.apache.org/jira/browse/MESOS-2277
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added help for roles.json, state-summary and edited help for state.json
>
>
> Fixed issues
>
>
> Diffs
> -----
>
> src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0
> src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564
> src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d
>
> Diff: https://reviews.apache.org/r/34926/diff/
>
>
> Testing
> -------
>
> Make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 34926: Added help for state.json
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34926/#review86203
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34926]
All tests passed.
- Mesos ReviewBot
On June 2, 2015, 6:34 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34926/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 6:34 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-2277
> https://issues.apache.org/jira/browse/MESOS-2277
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added help for roles.json, state-summary and edited help for state.json
>
>
> Fixed issues
>
>
> Diffs
> -----
>
> src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0
> src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564
> src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d
>
> Diff: https://reviews.apache.org/r/34926/diff/
>
>
> Testing
> -------
>
> Make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 34926: Added help for state.json
Posted by Aditi Dixit <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34926/
-----------------------------------------------------------
(Updated June 2, 2015, 6:34 a.m.)
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-2277
https://issues.apache.org/jira/browse/MESOS-2277
Repository: mesos
Description
-------
Added help for roles.json, state-summary and edited help for state.json
Fixed issues
Diffs
-----
src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0
src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564
src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d
Diff: https://reviews.apache.org/r/34926/diff/
Testing
-------
Make check
Thanks,
Aditi Dixit