You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/19 04:02:34 UTC
[GitHub] [apisix] LeBW opened a new pull request, #7081: Fix link of hot-reload in docs
LeBW opened a new pull request, #7081:
URL: https://github.com/apache/apisix/pull/7081
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fix link of hot-reload in docs
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lijing-21 commented on pull request #7081: docs: fix link of hot-reload in docs
Posted by GitBox <gi...@apache.org>.
lijing-21 commented on PR #7081:
URL: https://github.com/apache/apisix/pull/7081#issuecomment-1150619109
Hi @LeBW , thanks for the contribution!
Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)
[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #7081: Fix link of hot-reload in docs
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #7081:
URL: https://github.com/apache/apisix/pull/7081#discussion_r876627059
##########
docs/en/latest/FAQ.md:
##########
@@ -33,7 +33,7 @@ Apache APISIX differs in the following ways:
- It uses etcd to save and synchronize configurations rather than relational databases like PostgreSQL or MySQL. The real-time event notification system in etcd is easier to scale than in these alternatives. This allows APISIX to synchronize the configuration in real-time, makes the code concise and avoids a single point of failure.
- Fully dynamic.
-- Supports [hot loading of Plugins](/docs/apisix/plugins/#hot-reload).
+- Supports [hot loading of Plugins](terminology/plugin.md#hot-reload).
Review Comment:
```suggestion
- Supports [hot loading of Plugins](./terminology/plugin.md#hot-reload).
```
##########
docs/zh/latest/FAQ.md:
##########
@@ -34,7 +34,7 @@ Apache APISIX 在以下方面有所不同：
— 它使用 etcd 来保存和同步配置，而不是使用如 PostgreSQL 或 MySQL 这类的关系数据库。etcd 中的实时事件通知系统比这些替代方案更容易扩展。这允许 APISIX 实时同步配置，使代码简洁，并避免单点故障。
- 完全动态
-- 支持[热加载插件](/docs/apisix/terminology/plugin#热加载)。
+- 支持[热加载插件](terminology/plugin.md#热加载)。
Review Comment:
```suggestion
- 支持[热加载插件](./terminology/plugin.md#热加载)。
```
##########
docs/zh/latest/FAQ.md:
##########
@@ -252,7 +252,7 @@ nginx_config:
所有的 Apache APISIX 的插件都支持热加载的方式。
-如果你想了解更多关于热加载的内容，请参考[热加载](../terminology/plugin#热加载)。
+如果你想了解更多关于热加载的内容，请参考[热加载](terminology/plugin.md#热加载)。
Review Comment:
```suggestion
如果你想了解更多关于热加载的内容，请参考[热加载](./terminology/plugin.md#热加载)。
```
##########
docs/en/latest/FAQ.md:
##########
@@ -249,7 +249,7 @@ nginx_config:
All Plugins in Apache APISIX are hot reloaded.
-You can learn more about hot reloading of Plugins [here](https://apisix.apache.org/docs/apisix/architecture-design/plugin/#hot-reload).
+You can learn more about hot reloading of Plugins [here](terminology/plugin.md#hot-reload).
Review Comment:
```suggestion
You can learn more about hot reloading of Plugins [here](./terminology/plugin.md#hot-reload).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #7081: docs: fix link of hot-reload in docs
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #7081:
URL: https://github.com/apache/apisix/pull/7081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] LeBW commented on pull request #7081: Fix link of hot-reload in docs
Posted by GitBox <gi...@apache.org>.
LeBW commented on PR #7081:
URL: https://github.com/apache/apisix/pull/7081#issuecomment-1131286717
@hf400159 fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org