You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lécharny (Jira)" <ji...@apache.org> on 2024/03/31 22:39:00 UTC
[jira] [Resolved] (DIRSERVER-2395) SIMILAR_BRANCHES in ../codec/types/PaDataType.java
[ https://issues.apache.org/jira/browse/DIRSERVER-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lécharny resolved DIRSERVER-2395.
------------------------------------------
Fix Version/s: 2.0.0.AM28
Resolution: Fixed
The Kerberos related code has been removed from the server.
> SIMILAR_BRANCHES in ../codec/types/PaDataType.java
> --------------------------------------------------
>
> Key: DIRSERVER-2395
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2395
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 2.0.0.AM26
> Reporter: e.bykhanova
> Priority: Trivial
> Fix For: 2.0.0.AM28
>
> Attachments: image-2024-03-05-18-48-50-123.png, image-2024-03-05-18-49-32-439.png
>
>
> The static analyzer has detected {*}SIMILAR_BRANCHES{*}: here we have identical branches in switch node.
> All branches in this *switch* (function '{_}public static PaDataType getTypeByValue(int type){_}') correspond to the values of '{_}public enum Datatype{_}' (PaDataType.java:28-121). In this *enum* {*}PA_PK_AS_REQ{*}-value corresponds to the order *14* and \{*}PA_PK_AS_REP{*}-value corresponds to the order \{*}15{*}. It seems that the developer just overlooked that _the last letter_ in the values at PaDataType.java:184 and PaDataType.java:186 _should be different_ - the parameters PA_PK_AS_REQ and PA_PK_AS_REP look quite similar :)
>
> !image-2024-03-05-18-48-50-123.png!
>
> !image-2024-03-05-18-49-32-439.png!
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhanova@fobos-nt.ru).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org