[GitHub] [incubator-doris] imay commented on a change in pull request #1496: Add log to trace writer validate failure

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1496: Add log to trace writer validate failure
URL: https://github.com/apache/incubator-doris/pull/1496#discussion_r304372185
 
 

 ##########
 File path: be/src/olap/rowset/alpha_rowset.h
 ##########
 @@ -126,6 +126,10 @@ class AlphaRowset : public Rowset {
 
     std::string unique_id() override;
 
+    std::string rowset_path() const {
 
 Review comment:
   ```suggestion
       const std::string& rowset_path() const {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org