[GitHub] jiangphcn commented on issue #849: Fix external size bug when seq btree exists

[gi...@git.apache.org]

jiangphcn commented on issue #849: Fix external size bug when seq btree exists
URL: https://github.com/apache/couchdb/pull/849#issuecomment-335079694
 
 
   @tonysun83 LGTM. I also run newly introduced eunit test case and it passed.
   ```
   ======================== EUnit ========================
   Map views
   Application crypto was left running!
     couch_mrview_map_views_tests:68: should_map...ok
     couch_mrview_map_views_tests:82: should_map_with_range...ok
     couch_mrview_map_views_tests:96: should_map_with_limit_and_skip...ok
     couch_mrview_map_views_tests:113: should_map_with_include_docs...ok
     couch_mrview_map_views_tests:120: should_map_empty_views...ok
     couch_mrview_map_views_tests:141: should_give_ext_size_seq_indexed_test...ok
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
     [done in 0.669 s]
   =======================================================
     All 6 tests passed.
   ```
   I know that it is hard to compare actual size in eunit test case and ends up checking whether the returned size is reasonable number.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services