You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "GoGoWen (via GitHub)" <gi...@apache.org> on 2023/06/09 09:30:31 UTC
[GitHub] [doris] GoGoWen opened a new pull request, #20647: [Enhance](2PC) disable info log when 2pc
GoGoWen opened a new pull request, #20647:
URL: https://github.com/apache/doris/pull/20647
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233487415
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -425,7 +425,10 @@ public void preCommitTransaction2PC(List<Table> tableList, long transactionId,
unprotectedPreCommitTransaction2PC(transactionState, errorReplicaIds, tableToPartition,
totalInvolvedBackends, db);
- LOG.info("transaction:[{}] successfully pre-committed", transactionState);
Review Comment:
OK, debug level should be OK, which will cause performance issue in normal case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1597067710
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1596458661
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1592522956
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1596806751
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1590815700
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233068145
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -425,7 +425,10 @@ public void preCommitTransaction2PC(List<Table> tableList, long transactionId,
unprotectedPreCommitTransaction2PC(transactionState, errorReplicaIds, tableToPartition,
totalInvolvedBackends, db);
- LOG.info("transaction:[{}] successfully pre-committed", transactionState);
Review Comment:
Can it be changed to debug level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1597639452
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhance](2PC) disable info log when holding table write lock in 2pc [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1858992652
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1592615534
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1584366198
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233067854
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java:
##########
@@ -196,6 +198,9 @@ public void preCommitTransaction2PC(Database db, List<Table> tableList, long tra
} finally {
MetaLockUtils.writeUnlockTables(tableList);
}
+ stopWatch.stop();
+ LOG.info("stream load tasks are pre-committed successfully. txns: {}. time cost: {} ms."
+ + " data will be visible later.", transactionId, stopWatch.getTime());
Review Comment:
`data will be visible later.` May be ambiguous? Because it is in the precommit stage, unless the commit is actively triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1592492855
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1592960668
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGoWen commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "GoGoWen (via GitHub)" <gi...@apache.org>.
GoGoWen commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233487600
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java:
##########
@@ -196,6 +198,9 @@ public void preCommitTransaction2PC(Database db, List<Table> tableList, long tra
} finally {
MetaLockUtils.writeUnlockTables(tableList);
}
+ stopWatch.stop();
+ LOG.info("stream load tasks are pre-committed successfully. txns: {}. time cost: {} ms."
+ + " data will be visible later.", transactionId, stopWatch.getTime());
Review Comment:
sorry, seems "data will be visible later" should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233068348
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -675,7 +678,11 @@ public void commitTransaction(List<Table> tableList, long transactionId, List<Ta
// update nextVersion because of the failure of persistent transaction resulting in error version
updateCatalogAfterCommitted(transactionState, db);
- LOG.info("transaction:[{}] successfully committed", transactionState);
Review Comment:
the same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on code in PR #20647:
URL: https://github.com/apache/doris/pull/20647#discussion_r1233068145
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -425,7 +425,10 @@ public void preCommitTransaction2PC(List<Table> tableList, long transactionId,
unprotectedPreCommitTransaction2PC(transactionState, errorReplicaIds, tableToPartition,
totalInvolvedBackends, db);
- LOG.info("transaction:[{}] successfully pre-committed", transactionState);
Review Comment:
How about modifying to debug level？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20647:
URL: https://github.com/apache/doris/pull/20647#issuecomment-1596458738
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhance](2PC) disable info log when holding table write lock in 2pc [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc
URL: https://github.com/apache/doris/pull/20647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org