You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2023/03/03 12:18:03 UTC

[GitHub] [accumulo] cshannon opened a new pull request, #3222: Update Maven plugins to support Maven 3.9.0

cshannon opened a new pull request, #3222:
URL: https://github.com/apache/accumulo/pull/3222

   Jenkins build is failing after switch to Maven 3.9.0 due to plugin issues. This updates the plugins to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] ctubbsii commented on pull request #3222: Update Maven plugins to support Maven 3.9.0

Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #3222:
URL: https://github.com/apache/accumulo/pull/3222#issuecomment-1453657726

   > I'm surprised that the modernizer:2.5.0 plugin works. A fix for this issue was merged two weeks ago ([gaul/modernizer-maven-plugin#170](https://github.com/gaul/modernizer-maven-plugin/pull/170)) and modernizer:2.5.0 was released in November.
   
   It was fixed in https://github.com/gaul/modernizer-maven-plugin/pull/153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] cshannon merged pull request #3222: Update Maven plugins to support Maven 3.9.0

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #3222:
URL: https://github.com/apache/accumulo/pull/3222


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] dlmarion commented on pull request #3222: Update Maven plugins to support Maven 3.9.0

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3222:
URL: https://github.com/apache/accumulo/pull/3222#issuecomment-1453524013

   I'm surprised that the modernizer:2.5.0 plugin works. A fix for this issue was merged two weeks ago (https://github.com/gaul/modernizer-maven-plugin/pull/170) and modernizer:2.5.0 was released in November.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] cshannon commented on pull request #3222: Update Maven plugins to support Maven 3.9.0

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #3222:
URL: https://github.com/apache/accumulo/pull/3222#issuecomment-1453530761

   > I'm surprised that the modernizer:2.5.0 plugin works. A fix for this issue was merged two weeks ago ([gaul/modernizer-maven-plugin#170](https://github.com/gaul/modernizer-maven-plugin/pull/170)) and modernizer:2.5.0 was released in November.
   
   Yeah, I was surprised as well but I figured I'd try the latest of both plugins since they both had similar issues and it worked. 
   
   Also, as an FYI, I personally am still planning to use Maven 3.8.7 locally for now until 3.9.1 is released. There's a performance regression they highlighted in the release notes for 3.9.0 that has been fixed for 3.9.1 already: https://issues.apache.org/jira/browse/MNG-7677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] cshannon commented on pull request #3222: Update Maven plugins to support Maven 3.9.0

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #3222:
URL: https://github.com/apache/accumulo/pull/3222#issuecomment-1453470446

   The QA checks passed with the updated PR, I'm going to go ahead and merge as 2.1/main are currently broken building with Maven 3.9.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] dlmarion commented on pull request #3222: Update Maven plugins to support Maven 3.9.0

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3222:
URL: https://github.com/apache/accumulo/pull/3222#issuecomment-1453538368

   I'm using Maven 3.6.3 locally, so I only saw it on GitHub. Good find.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org