You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/10/18 21:52:05 UTC

[kudu-CR] Add missing comma in Impala CREATE TABLE statement 

Hello Will Berkeley,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8321

to review the following change.


Change subject: Add missing comma in Impala CREATE TABLE statement
......................................................................

Add missing comma in Impala CREATE TABLE statement

When the /table page was converted to use a Mustache template, a comma
got dropped from the generated SQL statement.

Change-Id: I699616634421eefcbfa4582130fdde098cbfd421
---
M www/table.mustache
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/8321/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I699616634421eefcbfa4582130fdde098cbfd421
Gerrit-Change-Number: 8321
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Add missing comma in Impala CREATE TABLE statement

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8321 )

Change subject: Add missing comma in Impala CREATE TABLE statement
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I699616634421eefcbfa4582130fdde098cbfd421
Gerrit-Change-Number: 8321
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Oct 2017 22:06:44 +0000
Gerrit-HasComments: No

[kudu-CR] Add missing comma in Impala CREATE TABLE statement

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8321 )

Change subject: Add missing comma in Impala CREATE TABLE statement
......................................................................

Add missing comma in Impala CREATE TABLE statement

When the /table page was converted to use a Mustache template, a comma
got dropped from the generated SQL statement.

Change-Id: I699616634421eefcbfa4582130fdde098cbfd421
Reviewed-on: http://gerrit.cloudera.org:8080/8321
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M www/table.mustache
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Will Berkeley: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I699616634421eefcbfa4582130fdde098cbfd421
Gerrit-Change-Number: 8321
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>