You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/18 20:06:02 UTC

[GitHub] [tinkerpop] xiazcy opened a new pull request, #1762: Gremlin-Go: skipping gremlin-go in TinkerPop Docker build integration

xiazcy opened a new pull request, #1762:
URL: https://github.com/apache/tinkerpop/pull/1762

   To avoid the Docker-in-Docker issue when a user tries to run Docker Integration with `docker/build.sh`, we'd like to remove the gremlin-go build from the build script for now. 
   
   A note is added in the documentations to direct users to run Gremlin-Go in Docker separately as instructed under `gremlin-go/driver/README.md`. 
   
   Progress involved in resolving this issue and re-enabling gremlin-go will be tracked under https://issues.apache.org/jira/browse/TINKERPOP-2737. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] kenhuuu commented on pull request #1762: Gremlin-Go: skipping gremlin-go in TinkerPop Docker build integration

Posted by GitBox <gi...@apache.org>.
kenhuuu commented on PR #1762:
URL: https://github.com/apache/tinkerpop/pull/1762#issuecomment-1192816550

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] codecov-commenter commented on pull request #1762: Gremlin-Go: skipping gremlin-go in TinkerPop Docker build integration

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1762:
URL: https://github.com/apache/tinkerpop/pull/1762#issuecomment-1188262777

   # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1762?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1762](https://codecov.io/gh/apache/tinkerpop/pull/1762?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28344d2) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/137cad03e7994b6ba08a15307c2d3d80a9f26f75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (137cad0) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff            @@
   ##           3.5-dev    #1762   +/-   ##
   ========================================
     Coverage    63.58%   63.58%           
   ========================================
     Files           23       23           
     Lines         3636     3636           
   ========================================
     Hits          2312     2312           
     Misses        1145     1145           
     Partials       179      179           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1762?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1762?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [137cad0...28344d2](https://codecov.io/gh/apache/tinkerpop/pull/1762?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] spmallette merged pull request #1762: Gremlin-Go: skipping gremlin-go in TinkerPop Docker build integration

Posted by GitBox <gi...@apache.org>.
spmallette merged PR #1762:
URL: https://github.com/apache/tinkerpop/pull/1762


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org