[GitHub] [incubator-tuweni] cleishm commented on issue #19: SSZ v0.5.0 Related Changes

[GitBox <gi...@apache.org>]

cleishm commented on issue #19: SSZ v0.5.0 Related Changes
URL: https://github.com/apache/incubator-tuweni/pull/19#issuecomment-500911722
 
 
   The hardest part of this change will be disambiguating method names for reading/writing variable length arrays/lists (with a user-controlled `limit` in the read case, for safety when reading untrusted data) and reading/writing fixed length arrays/lists. The current commits don't disambiguate well enough (e.g. the use of `readBytesList(...)` for both types). This will need to be addressed.
   
   Also, I believe this needs to be applied to arrays/lists of all types, for consistency. Currently, only arrays/lists of Bytes are handled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org