You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/16 21:00:59 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27871: [SPARK-31105][CORE]Respect sql execution id for FIFO scheduling mode

dongjoon-hyun commented on a change in pull request #27871: [SPARK-31105][CORE]Respect sql execution id for FIFO scheduling mode
URL: https://github.com/apache/spark/pull/27871#discussion_r393307959
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
 ##########
 @@ -111,8 +111,11 @@ private[spark] class TaskSetManager(
 
   val weight = 1
   val minShare = 0
-  var priority = taskSet.priority
-  var stageId = taskSet.stageId
+  val priority = if (taskSet.properties != null) {
+    taskSet.properties.getProperty("spark.sql.execution.id", "0").toLong
 
 Review comment:
   Although we has a similar one inside `AppStatusListener` already, this means another implicit dependency to `sql` module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org