You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Jarek Potiuk (Jira)" <ji...@apache.org> on 2020/01/21 13:03:00 UTC
[jira] [Updated] (AIRFLOW-6528) disable W503 flake8 check (line
break before binary operator)
[ https://issues.apache.org/jira/browse/AIRFLOW-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Potiuk updated AIRFLOW-6528:
----------------------------------
Fix Version/s: (was: 2.0.0)
1.10.8
> disable W503 flake8 check (line break before binary operator)
> -------------------------------------------------------------
>
> Key: AIRFLOW-6528
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6528
> Project: Apache Airflow
> Issue Type: Bug
> Components: pre-commit
> Affects Versions: 1.10.7
> Reporter: Daniel Standish
> Priority: Trivial
> Fix For: 1.10.8
>
>
> Flake8's W503 rule says there should be no line break before binary operator.
> This rule is incompatible with black formatter, and is also in my opinion bad style.
> Status quo example with W503 check enabled:
> {code}
> @property
> def sqlalchemy_scheme(self):
> """
> Database provided in init if exists; otherwise, ``schema`` from ``Connection`` object.
> """
> return (
> self._sqlalchemy_scheme or
> self.connection_extra_lower.get('sqlalchemy_scheme') or
> self.DEFAULT_SQLALCHEMY_SCHEME
> )
> {code}
> as required by black (W503 disabled)
> {code}
> @property
> def sqlalchemy_scheme(self):
> """
> Database provided in init if exists; otherwise, ``schema`` from ``Connection`` object.
> """
> return (
> self._sqlalchemy_scheme
> or self.connection_extra_lower.get('sqlalchemy_scheme')
> or self.DEFAULT_SQLALCHEMY_SCHEME
> )
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)