You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Bharat Viswanadham <bh...@us.ibm.com> on 2017/04/13 19:37:22 UTC
Review Request 58431: Update zookeeper.connect description
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Di Li.
Repository: ambari
Description
-------
Update zookeeper.connect description
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
Diff: https://reviews.apache.org/r/58431/diff/1/
Testing
-------
Thanks,
Bharat Viswanadham
Re: Review Request 58431: Update zookeeper.connect description
Posted by Bharat Viswanadham <bh...@us.ibm.com>.
> On April 13, 2017, 7:54 p.m., Di Li wrote:
> > hello Bharat,
> >
> > Could you please update the review board request with the Ambari JIRA ID , branch the issue applies, tests done, etc ?
Updated fields required.
- Bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171925
-----------------------------------------------------------
On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update zookeeper.connect description
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
>
>
> Diff: https://reviews.apache.org/r/58431/diff/1/
>
>
> Testing
> -------
>
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the zookeeper.connect to <<host>>:<<port>>/chroot/path and Kafka Broker is successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path --from-beginning --topic ambari_service_check
> This also worked fine.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58431: Update zookeeper.connect description
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171925
-----------------------------------------------------------
hello Bharat,
Could you please update the review board request with the Ambari JIRA ID , branch the issue applies, tests done, etc ?
- Di Li
On April 13, 2017, 7:37 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 7:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update zookeeper.connect description
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
>
>
> Diff: https://reviews.apache.org/r/58431/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58431: Update zookeeper.connect description
Posted by Di Li <di...@ca.ibm.com>.
> On April 13, 2017, 8:26 p.m., Di Li wrote:
> > Ship It!
>
> Bharat Viswanadham wrote:
> Hi Di,
> Could you please help in commit these changes.
please close this RB request as the change is pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=dd3fdc220d9ad3b2b723a201ce7aa5d767850a58 now.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171929
-----------------------------------------------------------
On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update zookeeper.connect description
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
>
>
> Diff: https://reviews.apache.org/r/58431/diff/1/
>
>
> Testing
> -------
>
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the zookeeper.connect to <<host>>:<<port>>/chroot/path and Kafka Broker is successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path --from-beginning --topic ambari_service_check
> This also worked fine.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58431: Update zookeeper.connect description
Posted by Bharat Viswanadham <bh...@us.ibm.com>.
> On April 13, 2017, 8:26 p.m., Di Li wrote:
> > Ship It!
Hi Di,
Could you please help in commit these changes.
- Bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171929
-----------------------------------------------------------
On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update zookeeper.connect description
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
>
>
> Diff: https://reviews.apache.org/r/58431/diff/1/
>
>
> Testing
> -------
>
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the zookeeper.connect to <<host>>:<<port>>/chroot/path and Kafka Broker is successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path --from-beginning --topic ambari_service_check
> This also worked fine.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58431: Update zookeeper.connect description
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171929
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update zookeeper.connect description
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
>
>
> Diff: https://reviews.apache.org/r/58431/diff/1/
>
>
> Testing
> -------
>
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the zookeeper.connect to <<host>>:<<port>>/chroot/path and Kafka Broker is successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path --from-beginning --topic ambari_service_check
> This also worked fine.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58431: Update zookeeper.connect description
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171944
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 13, 2017, 8:11 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58431/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20761
> https://issues.apache.org/jira/browse/AMBARI-20761
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update zookeeper.connect description
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
>
>
> Diff: https://reviews.apache.org/r/58431/diff/1/
>
>
> Testing
> -------
>
> It is a document change. Changed the description.
> Tested it with install Kafka and zookeeper with change in the zookeeper.connect to <<host>>:<<port>>/chroot/path and Kafka Broker is successfully started.
> And tried running console consumer
> bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path --from-beginning --topic ambari_service_check
> This also worked fine.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58431: Update zookeeper.connect description
Posted by Bharat Viswanadham <bh...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/
-----------------------------------------------------------
(Updated April 13, 2017, 8:11 p.m.)
Review request for Ambari, Alejandro Fernandez and Di Li.
Bugs: AMBARI-20761
https://issues.apache.org/jira/browse/AMBARI-20761
Repository: ambari
Description
-------
Update zookeeper.connect description
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750
Diff: https://reviews.apache.org/r/58431/diff/1/
Testing (updated)
-------
It is a document change. Changed the description.
Tested it with install Kafka and zookeeper with change in the zookeeper.connect to <<host>>:<<port>>/chroot/path and Kafka Broker is successfully started.
And tried running console consumer
bin/kafka-console-consumer.sh --zookeeper heel1.fyre.ibm.com:2181/kafka/path --from-beginning --topic ambari_service_check
This also worked fine.
Thanks,
Bharat Viswanadham