[GitHub] [pulsar-client-go] merlimat commented on pull request #310: Share buffer pool across all partitions

[GitBox <gi...@apache.org>]

merlimat commented on pull request #310:
URL: https://github.com/apache/pulsar-client-go/pull/310#issuecomment-655776643


   > just only some concerns whether the use of sync.pool here will cause GC pressure because sync.Pool cannot specify a size, which is only subject to the GC threshold.
   
   Using the pool will not causing GC pressure itself: it's actually there to avoid the GC pressure. 
   
   The pool having no max size is not a big problem. The max amount of memory is still determined by the "pending" messages whose payloads are buffered until they get acknowledged by the broker. 
   
   This change is to use a single pool to avoid that each pool will have a few buffers that cannot be immediately reused. After this change, the memory usage is the same as without the pooling.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org