You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Max Starets (JIRA)" <de...@myfaces.apache.org> on 2007/10/16 19:41:50 UTC

[jira] Created: (TRINIDAD-772) Setting "First" to -1 makes UIXIterator scroll to the end

Setting "First" to -1 makes UIXIterator scroll to the end
---------------------------------------------------------

                 Key: TRINIDAD-772
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-772
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 1.2.2-core
            Reporter: Max Starets
             Fix For: 1.2.3-core
         Attachments: fixupFirst.patch

When "first" property is set to -1, UIXIterator assumes that the row is not available and scrolls to the end. The logic is there to handle cases when some records have been deleted and "first" points to an index >= rowCount. However, we should not be applying this logic to a negative "first". Instead, it should be just s et to 0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (TRINIDAD-772) Setting "First" to -1 makes UIXIterator scroll to the end

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated TRINIDAD-772:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.3-core
                   1.0.4-core
           Status: Resolved  (was: Patch Available)

thx to max for his patch.
applied to 104 and 123

> Setting "First" to -1 makes UIXIterator scroll to the end
> ---------------------------------------------------------
>
>                 Key: TRINIDAD-772
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-772
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.3-core, 1.2.2-core
>            Reporter: Max Starets
>            Assignee: Matthias Weßendorf
>             Fix For: 1.0.4-core, 1.2.3-core
>
>         Attachments: fixupFirst.patch
>
>
> When "first" property is set to -1, UIXIterator assumes that the row is not available and scrolls to the end. The logic is there to handle cases when some records have been deleted and "first" points to an index >= rowCount. However, we should not be applying this logic to a negative "first". Instead, it should be just set to 0.
> The affected method is UIXIteratir._fixupFirst() (see provided patch)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (TRINIDAD-772) Setting "First" to -1 makes UIXIterator scroll to the end

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535516 ] 

Matthias Weßendorf commented on TRINIDAD-772:
---------------------------------------------

looks like this is true for the 1.0.x as well

> Setting "First" to -1 makes UIXIterator scroll to the end
> ---------------------------------------------------------
>
>                 Key: TRINIDAD-772
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-772
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.2-core
>            Reporter: Max Starets
>             Fix For: 1.2.3-core
>
>         Attachments: fixupFirst.patch
>
>
> When "first" property is set to -1, UIXIterator assumes that the row is not available and scrolls to the end. The logic is there to handle cases when some records have been deleted and "first" points to an index >= rowCount. However, we should not be applying this logic to a negative "first". Instead, it should be just set to 0.
> The affected method is UIXIteratir._fixupFirst() (see provided patch)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (TRINIDAD-772) Setting "First" to -1 makes UIXIterator scroll to the end

Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Starets updated TRINIDAD-772:
---------------------------------

    Status: Patch Available  (was: Open)

> Setting "First" to -1 makes UIXIterator scroll to the end
> ---------------------------------------------------------
>
>                 Key: TRINIDAD-772
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-772
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.2-core
>            Reporter: Max Starets
>             Fix For: 1.2.3-core
>
>         Attachments: fixupFirst.patch
>
>
> When "first" property is set to -1, UIXIterator assumes that the row is not available and scrolls to the end. The logic is there to handle cases when some records have been deleted and "first" points to an index >= rowCount. However, we should not be applying this logic to a negative "first". Instead, it should be just s et to 0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.