You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/02/10 07:39:57 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #588: docs: update flaky test template and pr template
kaijchen opened a new pull request, #588:
URL: https://github.com/apache/incubator-uniffle/pull/588
### What changes were proposed in this pull request?
Update flaky test template and pr template.
### Why are the changes needed?
1. Flaky test template
* Title is not consistent with other templates.
* Default parent issue is invalid.
2. PR template
* It's a burden to remove inlined comments every time.
* Update instructions, and add example for PR title #551
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #588: [#551] docs: update flaky test and pull request template
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102425143
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
Review Comment:
This is ambiguous. -> `[#ISSUE-NUMBER]`?
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
Review Comment:
Cloud you add an PR title example here, such as
`[#123] docs: update pull request template`
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
Review Comment:
This is not clear. Please add more comments about this section.
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
### Does this PR introduce _any_ user-facing change?
-<!--
-Note that it means *any* user-facing change including all aspects such as the documentation fix.
-If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
-If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
-If no, write 'No'.
--->
+Please list the user-facing changes introduced by your change, including
+ 1. change in user-facing APIs
+ 2. addition or removal of property keys
Review Comment:
3. if no user-facing changes introduced, simply write 'NO'
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
Review Comment:
You should document these lines should be replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1104462936
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,39 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+1. Title: [#<issue>]<type>(<scope>): <subject>
Review Comment:
```suggestion
1. Title: [#<issue>] <type>(<scope>): <subject>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1108213808
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,39 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+1. Title: [#<issue>]<type>(<scope>): <subject>
+ Examples:
+ - "[#123] feat(operator): support xxx"
+ - "[#233] fix: check null before access result in xxx"
+ - "[MINOR] refactor: fix typo in variable name"
+ - "[MINOR] docs: fix typo in README"
+ - "[#255] test: fix flaky test NameOfTheTest"
+ Reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
Review Comment:
why not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update flaky test and pull request template
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102446396
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
### Does this PR introduce _any_ user-facing change?
-<!--
-Note that it means *any* user-facing change including all aspects such as the documentation fix.
-If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
-If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
-If no, write 'No'.
--->
+Please list the user-facing changes introduced by your change, including
+ 1. change in user-facing APIs
+ 2. addition or removal of property keys
Review Comment:
Added default answer: "No."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1108228646
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,39 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+1. Title: [#<issue>] <type>(<scope>): <subject>
+ Examples:
+ - "[#123] feat(operator): support xxx"
+ - "[#233] fix: check null before access result in xxx"
+ - "[MINOR] refactor: fix typo in variable name"
+ - "[MINOR] docs: fix typo in README"
+ - "[#255] test: fix flaky test NameOfTheTest"
+ Reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
Review Comment:
```suggestion
Reference: https://www.conventionalcommits.org/en/v1.0.0/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update flaky test and pull request template
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102438826
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
Review Comment:
WDYM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update flaky test and pull request template
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102450793
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
Review Comment:
This is for reminding PR author to link the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #588: [#551] docs: update flaky test and pull request template
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#issuecomment-1425361519
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#588](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8a781) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/fdc27436ced85e95bdfe6801e2fd22e575b40aed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fdc2743) will **decrease** coverage by `0.32%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #588 +/- ##
============================================
- Coverage 60.84% 60.52% -0.32%
+ Complexity 1797 1572 -225
============================================
Files 214 192 -22
Lines 12398 10554 -1844
Branches 1051 887 -164
============================================
- Hits 7543 6388 -1155
+ Misses 4445 3801 -644
+ Partials 410 365 -45
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...preduce/task/reduce/RssRemoteMergeManagerImpl.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc1JlbW90ZU1lcmdlTWFuYWdlckltcGwuamF2YQ==) | | |
| [...org/apache/spark/shuffle/RssSparkShuffleUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya1NodWZmbGVVdGlscy5qYXZh) | | |
| [...mapreduce/task/reduce/RssInMemoryRemoteMerger.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0luTWVtb3J5UmVtb3RlTWVyZ2VyLmphdmE=) | | |
| [...java/org/apache/hadoop/mapred/SortWriteBuffer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkL1NvcnRXcml0ZUJ1ZmZlci5qYXZh) | | |
| [...k/shuffle/writer/WrappedByteArrayOutputStream.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JhcHBlZEJ5dGVBcnJheU91dHB1dFN0cmVhbS5qYXZh) | | |
| [...che/spark/shuffle/writer/BufferManagerOptions.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQnVmZmVyTWFuYWdlck9wdGlvbnMuamF2YQ==) | | |
| [...org/apache/spark/shuffle/writer/AddBlockEvent.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQWRkQmxvY2tFdmVudC5qYXZh) | | |
| [.../java/org/apache/spark/shuffle/RssSparkConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya0NvbmZpZy5qYXZh) | | |
| [...rg/apache/hadoop/mapred/RssMapOutputCollector.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkL1Jzc01hcE91dHB1dENvbGxlY3Rvci5qYXZh) | | |
| [.../hadoop/mapreduce/task/reduce/RssBypassWriter.java](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0J5cGFzc1dyaXRlci5qYXZh) | | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-uniffle/pull/588?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update flaky test and pull request template
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102445638
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
Review Comment:
Is it enough to put the tips in parentheses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1118390097
##########
.github/ISSUE_TEMPLATE/flaky-test-report.yml:
##########
@@ -66,7 +66,7 @@ body:
- type: textarea
attributes:
label: Parent issue
- value: "#1733"
+ value: ""
Review Comment:
`value` must be of type String and cannot be empty. @kaijchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1118398133
##########
.github/ISSUE_TEMPLATE/flaky-test-report.yml:
##########
@@ -66,7 +66,7 @@ body:
- type: textarea
attributes:
label: Parent issue
- value: "#1733"
+ value: ""
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1118392292
##########
.github/ISSUE_TEMPLATE/flaky-test-report.yml:
##########
@@ -66,7 +66,7 @@ body:
- type: textarea
attributes:
label: Parent issue
- value: "#1733"
+ value: ""
Review Comment:
Thanks, can you submit a PR to fix it?
Maybe let's just remove this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#issuecomment-1427484315
> Thanks @advancedxy @jerqi for the review. Although there might be some concerns, PPMC members and committers are able to edit the PR title and description. I think we can give it a try.
Yeah. I think so. However is it possible for you to write a `COMMITTER_GUIDE.md` in the repo root dir? The `COMMITTER_GUIDE` should be how to modify the pr title/summary before merging a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update flaky test and pull request template
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102450793
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
Review Comment:
This is to remind PR author to link the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102501315
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
Review Comment:
How to change it? How about this?
```suggestion
Fix: #(issue id)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1104091792
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,39 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+1. Title: [#<issue>]<type>(<scope>): <subject>
+ Examples:
+ - "[#123] feat(operator): support xxx"
+ - "[#233] fix: check null before access result in xxx"
+ - "[MINOR] refactor: fix typo in variable name"
+ - "[MINOR] docs: fix typo in README"
+ - "[#255] test: fix flaky test NameOfTheTest"
+ Reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
Review Comment:
is it a good idea to reference a gist url here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1108223994
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,39 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+1. Title: [#<issue>]<type>(<scope>): <subject>
+ Examples:
+ - "[#123] feat(operator): support xxx"
+ - "[#233] fix: check null before access result in xxx"
+ - "[MINOR] refactor: fix typo in variable name"
+ - "[MINOR] docs: fix typo in README"
+ - "[#255] test: fix flaky test NameOfTheTest"
+ Reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
Review Comment:
I prefer a formal URL, such as the conventional commit urk: https://www.conventionalcommits.org/en/v1.0.0/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #588: [#551] docs: update flaky test and pull request template
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#issuecomment-1425444659
Thanks @advancedxy @jerqi for the review.
Although there might be some concerns, PPMC members and committers are able to edit the PR title and description.
I think we can give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1102498728
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,34 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+Thanks for sending a pull request! Here are some tips for you:
+ 1. If this is your first time, please read our contributor guidelines:
+ https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
+ 2. Please write your PR title to summarize what this PR proposes.
+ The preferred format is: "[#issue] type(scope): summary"
+ If there is no need to link to a issue: "[MINOR] type(scope): summary"
+ For reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
+ 3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
-<!--
-Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
-If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
- 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- 2. If you fix some SQL features, you can provide some references of other DBMSes.
- 3. If there is design documentation, please add the link.
- 4. If there is a discussion in the mailing list, please add the link.
--->
+Please outline the changes and how this PR fixes the issue.
### Why are the changes needed?
-<!--
+
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
- 2. If you fix a bug, you can clarify why it is a bug.
--->
+ 2. If you fix a bug, describe the bug.
+Fix: #
Review Comment:
I know you intention. But contributor may got confused about what this is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#discussion_r1108226044
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -1,44 +1,39 @@
<!--
-Thanks for sending a pull request! Here are some tips for you:
- 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
- 2. Ensure you have added or run the appropriate tests for your PR
- 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
- 4. Be sure to keep the PR description updated to reflect all changes.
- 5. Please write your PR title to summarize what this PR proposes.
- 6. If possible, provide a concise example to reproduce the issue for a faster review.
+1. Title: [#<issue>]<type>(<scope>): <subject>
+ Examples:
+ - "[#123] feat(operator): support xxx"
+ - "[#233] fix: check null before access result in xxx"
+ - "[MINOR] refactor: fix typo in variable name"
+ - "[MINOR] docs: fix typo in README"
+ - "[#255] test: fix flaky test NameOfTheTest"
+ Reference: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716
Review Comment:
Let's make it a bit clear:
We are proposing an PR title that prefixed with github's issut autolink then a conventional commits title?
The conventional commit could be referred: https://www.conventionalcommits.org/en/v1.0.0/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #588: [#551] docs: update templates for flaky test and pull request
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #588:
URL: https://github.com/apache/incubator-uniffle/pull/588#issuecomment-1433051076
Thanks @advancedxy and @jerqi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org