You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by Nuwan Jayawardene <ns...@gmail.com> on 2022/06/03 09:35:16 UTC
Re: Pull request template for Synapse
Hi all,
>
> While working on Synapse I noticed that there was no template for pull
> requests as seen in other open-source projects. Therefore I went ahead and
> added a template based on the one present in the WSO2 micro-integrator repo
> (and other WSO2 products).
>
kind follow-up for some feedback on this.
Thanks and regards
On Thu, May 19, 2022 at 7:00 PM Nuwan Jayawardene <ns...@gmail.com> wrote:
> Hi all,
> While working on Synapse I noticed that there was no template for pull
> requests as seen in other open-source projects. Therefore I went ahead and
> added a template based on the one present in the WSO2 micro-integrator repo
> (and other WSO2 products).
>
> The associated PR is linked herewith:
> https://github.com/apache/synapse/pull/59
>
> Kind regards
> --
> *Nuwan Jayawardene*
> Assistant Lecturer, Informatics Institute of Technology (IIT).
> Research Assistant, University of Moratuwa
>
> https://www.linkedin.com/m/in/nuwanjaya
>
>
>
--
*Nuwan Jayawardene*
Assistant Lecturer, Informatics Institute of Technology (IIT).
Research Assistant, University of Moratuwa
https://www.linkedin.com/m/in/nuwanjaya
Re: Pull request template for Synapse
Posted by Nuwan Jayawardene <ns...@gmail.com>.
Hi all,
kind follow-up on feedback for the PR template structure
https://github.com/apache/synapse/pull/59
Regards
On Sat, Jun 4, 2022 at 12:00 PM Nuwan Jayawardene <ns...@gmail.com> wrote:
> Hi Isuru
>
>> But by looking at the template you have used, I think some fields are not
>> useful.
>> Let's discuss and comeup with a new template for us.
>>
> Understood. I'm not quite familiar with the process when getting
> a consensus from the community regarding a decision.
> Do we discuss this further via a separate code review (for this specific
> PR) or in this thread itself?
>
> Thanks and regards
>
>
>
>
> On Fri, Jun 3, 2022 at 10:53 PM Isuru Udana <is...@gmail.com> wrote:
>
>> Hi Nuwan,
>>
>> Yes we don't have a template for pull request description.
>> I am +1 to create something.
>> But by looking at the template you have used, I think some fields are not
>> useful.
>> Let's discuss and comeup with a new template for us.
>>
>> Thanks.
>>
>> On Fri, 3 Jun 2022, 15:05 Nuwan Jayawardene, <ns...@gmail.com> wrote:
>>
>>> Hi all,
>>>>
>>>> While working on Synapse I noticed that there was no template for pull
>>>> requests as seen in other open-source projects. Therefore I went ahead and
>>>> added a template based on the one present in the WSO2 micro-integrator repo
>>>> (and other WSO2 products).
>>>>
>>> kind follow-up for some feedback on this.
>>>
>>> Thanks and regards
>>>
>>>
>>>
>>>
>>>
>>> On Thu, May 19, 2022 at 7:00 PM Nuwan Jayawardene <ns...@gmail.com>
>>> wrote:
>>>
>>>> Hi all,
>>>> While working on Synapse I noticed that there was no template for pull
>>>> requests as seen in other open-source projects. Therefore I went ahead and
>>>> added a template based on the one present in the WSO2 micro-integrator repo
>>>> (and other WSO2 products).
>>>>
>>>> The associated PR is linked herewith:
>>>> https://github.com/apache/synapse/pull/59
>>>>
>>>> Kind regards
>>>> --
>>>> *Nuwan Jayawardene*
>>>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>>>> Research Assistant, University of Moratuwa
>>>>
>>>> https://www.linkedin.com/m/in/nuwanjaya
>>>>
>>>>
>>>>
>>>
>>> --
>>> *Nuwan Jayawardene*
>>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>>> Research Assistant, University of Moratuwa
>>>
>>> https://www.linkedin.com/m/in/nuwanjaya
>>>
>>>
>>>
>
> --
> *Nuwan Jayawardene*
> Assistant Lecturer, Informatics Institute of Technology (IIT).
> Research Assistant, University of Moratuwa
>
> https://www.linkedin.com/m/in/nuwanjaya
>
>
--
*Nuwan Jayawardene*
Assistant Lecturer, Informatics Institute of Technology (IIT).
Research Assistant, University of Moratuwa
https://www.linkedin.com/m/in/nuwanjaya
Re: Pull request template for Synapse
Posted by Nuwan Jayawardene <ns...@gmail.com>.
Hi Isuru
> But by looking at the template you have used, I think some fields are not
> useful.
> Let's discuss and comeup with a new template for us.
>
Understood. I'm not quite familiar with the process when getting
a consensus from the community regarding a decision.
Do we discuss this further via a separate code review (for this specific
PR) or in this thread itself?
Thanks and regards
On Fri, Jun 3, 2022 at 10:53 PM Isuru Udana <is...@gmail.com> wrote:
> Hi Nuwan,
>
> Yes we don't have a template for pull request description.
> I am +1 to create something.
> But by looking at the template you have used, I think some fields are not
> useful.
> Let's discuss and comeup with a new template for us.
>
> Thanks.
>
> On Fri, 3 Jun 2022, 15:05 Nuwan Jayawardene, <ns...@gmail.com> wrote:
>
>> Hi all,
>>>
>>> While working on Synapse I noticed that there was no template for pull
>>> requests as seen in other open-source projects. Therefore I went ahead and
>>> added a template based on the one present in the WSO2 micro-integrator repo
>>> (and other WSO2 products).
>>>
>> kind follow-up for some feedback on this.
>>
>> Thanks and regards
>>
>>
>>
>>
>>
>> On Thu, May 19, 2022 at 7:00 PM Nuwan Jayawardene <ns...@gmail.com>
>> wrote:
>>
>>> Hi all,
>>> While working on Synapse I noticed that there was no template for pull
>>> requests as seen in other open-source projects. Therefore I went ahead and
>>> added a template based on the one present in the WSO2 micro-integrator repo
>>> (and other WSO2 products).
>>>
>>> The associated PR is linked herewith:
>>> https://github.com/apache/synapse/pull/59
>>>
>>> Kind regards
>>> --
>>> *Nuwan Jayawardene*
>>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>>> Research Assistant, University of Moratuwa
>>>
>>> https://www.linkedin.com/m/in/nuwanjaya
>>>
>>>
>>>
>>
>> --
>> *Nuwan Jayawardene*
>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>> Research Assistant, University of Moratuwa
>>
>> https://www.linkedin.com/m/in/nuwanjaya
>>
>>
>>
--
*Nuwan Jayawardene*
Assistant Lecturer, Informatics Institute of Technology (IIT).
Research Assistant, University of Moratuwa
https://www.linkedin.com/m/in/nuwanjaya
Re: Pull request template for Synapse
Posted by Isuru Udana <is...@gmail.com>.
Hi Nuwan,
Yes we don't have a template for pull request description.
I am +1 to create something.
But by looking at the template you have used, I think some fields are not
useful.
Let's discuss and comeup with a new template for us.
Thanks.
On Fri, 3 Jun 2022, 15:05 Nuwan Jayawardene, <ns...@gmail.com> wrote:
> Hi all,
>>
>> While working on Synapse I noticed that there was no template for pull
>> requests as seen in other open-source projects. Therefore I went ahead and
>> added a template based on the one present in the WSO2 micro-integrator repo
>> (and other WSO2 products).
>>
> kind follow-up for some feedback on this.
>
> Thanks and regards
>
>
>
>
>
> On Thu, May 19, 2022 at 7:00 PM Nuwan Jayawardene <ns...@gmail.com>
> wrote:
>
>> Hi all,
>> While working on Synapse I noticed that there was no template for pull
>> requests as seen in other open-source projects. Therefore I went ahead and
>> added a template based on the one present in the WSO2 micro-integrator repo
>> (and other WSO2 products).
>>
>> The associated PR is linked herewith:
>> https://github.com/apache/synapse/pull/59
>>
>> Kind regards
>> --
>> *Nuwan Jayawardene*
>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>> Research Assistant, University of Moratuwa
>>
>> https://www.linkedin.com/m/in/nuwanjaya
>>
>>
>>
>
> --
> *Nuwan Jayawardene*
> Assistant Lecturer, Informatics Institute of Technology (IIT).
> Research Assistant, University of Moratuwa
>
> https://www.linkedin.com/m/in/nuwanjaya
>
>
>