[GitHub] [helix] narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #456: Add delayed rebalance and user-defined preference list features to the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/456#discussion_r329883026
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancer.java
 ##########
 @@ -112,7 +112,8 @@ protected ResourceControllerDataProvider setupClusterDataCache() throws IOExcept
   @Test
   public void testRebalance() throws IOException, HelixRebalanceException {
     _metadataStore.clearMetadataStore();
-    WagedRebalancer rebalancer = new WagedRebalancer(_metadataStore, _algorithm);
+    WagedRebalancer rebalancer =
+        new WagedRebalancer(_metadataStore, _algorithm, new DelayedAutoRebalancer(), null);
 
 Review comment:
   Create a constructor without the last field?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org