You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "myskov (via GitHub)" <gi...@apache.org> on 2023/08/31 05:40:55 UTC
[GitHub] [ozone] myskov opened a new pull request, #5238: HDDS-9230. Add CLI command for checking native libs
myskov opened a new pull request, #5238:
URL: https://github.com/apache/ozone/pull/5238
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9230
## How was this patch tested?
added a unit test for a case where native libs are not provided. Other cases are tricky to mock so I did manual testing:
Native libs not provided:
`$ ozone checknative
Native library checking:
hadoop: false
ISA-L: false`
Only hadooplib is provided:
`$ ozone checknative
Native library checking:
hadoop: true /root/lib/libhadoop.so
ISA-L: false Loading ISA-L failed: Failed to load libisal.so.2 (libisal.so.2: cannot open shared object file: No such file or directory)`
Hadooplib and isa-l are provided:
`$ ozone checknative
Native library checking:
hadoop: true /root/lib/libhadoop.so
ISA-L: true /lib64/libisal.so.2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "myskov (via GitHub)" <gi...@apache.org>.
myskov commented on PR #5238:
URL: https://github.com/apache/ozone/pull/5238#issuecomment-1705438770
@ayushtkn since there's 3 approves and no objections, could you please merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "Xushaohong (via GitHub)" <gi...@apache.org>.
Xushaohong commented on PR #5238:
URL: https://github.com/apache/ozone/pull/5238#issuecomment-1702811122
I am not sure if this CLI is necessary enough, but this looks like a good shell function.
If it is get merged, you could take a look at **smoketest** and add a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "Xushaohong (via GitHub)" <gi...@apache.org>.
Xushaohong commented on PR #5238:
URL: https://github.com/apache/ozone/pull/5238#issuecomment-1702803700
> @Xushaohong thanks for the review. There's a failed flaky test, what should I do? Retrigger verification by pushing an empty commit? I don't have permissions to retrigger the verification manually
Once you have confirmed the failed CI is irrelevant, you could have a few options:
1. Push an empty commit, this will trigger a new run of CICD.
```git commit --allow-empty -m "retrigger ci" && git push xxxxxx```
2. Comment and claim that the failed UT is irrelevant.
Better to make sure the CICD successfully ran on your own repo.
3. Ask the committer (who has rights to rerun the failed test) to help you rerun.
4. Just wait for others to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "myskov (via GitHub)" <gi...@apache.org>.
myskov commented on PR #5238:
URL: https://github.com/apache/ozone/pull/5238#issuecomment-1702536055
@Xushaohong thanks for the review. There's a failed flaky test, what should I do? Retrigger verification by pushing an empty commit? I don't have permissions to retrigger the verficiation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn merged pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn merged PR #5238:
URL: https://github.com/apache/ozone/pull/5238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #5238:
URL: https://github.com/apache/ozone/pull/5238#issuecomment-1705752820
Thanx @myskov for the contribution, @Xushaohong & @smengcl for the reviews!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on pull request #5238: HDDS-9230. Add CLI command for checking native libs
Posted by "myskov (via GitHub)" <gi...@apache.org>.
myskov commented on PR #5238:
URL: https://github.com/apache/ozone/pull/5238#issuecomment-1703096775
@ayushtkn could you please retrigger workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org