You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/05 03:19:08 UTC
Review Request 37108: Remove unused failover functionality in
scheduler library
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37108/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
We now leave it upto the client to set the force option when making the subscribe call. This existed in the pre-Call era as force(failover) was not exposed to the scheduler. ( was part of FrameworkReRegisterMessage not exposed to the scheduler )
We anyways were not using this as of now.
Diffs
-----
src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
Diff: https://reviews.apache.org/r/37108/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37108: Remove unused failover functionality in
scheduler library
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37108/#review94170
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 5, 2015, 1:19 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37108/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 1:19 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now leave it upto the client to set the force option when making the subscribe call. This existed in the pre-Call era as force(failover) was not exposed to the scheduler. ( was part of FrameworkReRegisterMessage not exposed to the scheduler )
>
> We anyways were not using this as of now.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
>
> Diff: https://reviews.apache.org/r/37108/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37108: Remove unused failover functionality in
scheduler library
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37108/#review94400
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37108]
All tests passed.
- Mesos ReviewBot
On Aug. 5, 2015, 1:19 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37108/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 1:19 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now leave it upto the client to set the force option when making the subscribe call. This existed in the pre-Call era as force(failover) was not exposed to the scheduler. ( was part of FrameworkReRegisterMessage not exposed to the scheduler )
>
> We anyways were not using this as of now.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
>
> Diff: https://reviews.apache.org/r/37108/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37108: Remove unused failover functionality in
scheduler library
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37108/#review94387
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Aug. 5, 2015, 3:19 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37108/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 3:19 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now leave it upto the client to set the force option when making the subscribe call. This existed in the pre-Call era as force(failover) was not exposed to the scheduler. ( was part of FrameworkReRegisterMessage not exposed to the scheduler )
>
> We anyways were not using this as of now.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
>
> Diff: https://reviews.apache.org/r/37108/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>