You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wombatu-kun (via GitHub)" <gi...@apache.org> on 2024/04/06 14:51:36 UTC

[PR] [MINOR] Removed code duplicates in HoodieClients [hudi]

wombatu-kun opened a new pull request, #10967:
URL: https://github.com/apache/hudi/pull/10967

   ### Change Logs
   
   - Moved `writeTableMetadata` from `BaseHoodieWriteClient` to `BaseHoodieClient` and remove it from `BaseHoodieTableServiceClient`;  
   - Removed `postWrite` from `HoodieJavaWriteClient` (as the same implementation exist in it's parent class `BaseHoodieWriteClient`);  
   - Fixed logging in `BaseHoodieTableServiceClient`.
   
   ### Impact
   
   none
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   none
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Removed code duplicates in HoodieClients [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10967:
URL: https://github.com/apache/hudi/pull/10967#issuecomment-2041118585

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b7c3cbe075e507cf31d48c5032b956a3601a9c3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23134",
       "triggerID" : "1b7c3cbe075e507cf31d48c5032b956a3601a9c3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b7c3cbe075e507cf31d48c5032b956a3601a9c3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23134) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Removed code duplicates in HoodieClients [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #10967:
URL: https://github.com/apache/hudi/pull/10967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Removed code duplicates in HoodieClients [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10967:
URL: https://github.com/apache/hudi/pull/10967#issuecomment-2041117053

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b7c3cbe075e507cf31d48c5032b956a3601a9c3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1b7c3cbe075e507cf31d48c5032b956a3601a9c3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b7c3cbe075e507cf31d48c5032b956a3601a9c3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Removed code duplicates in HoodieClients [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10967:
URL: https://github.com/apache/hudi/pull/10967#issuecomment-2041131351

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b7c3cbe075e507cf31d48c5032b956a3601a9c3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23134",
       "triggerID" : "1b7c3cbe075e507cf31d48c5032b956a3601a9c3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b7c3cbe075e507cf31d48c5032b956a3601a9c3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23134) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org